FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixes #3150 - Ignores resource key when it isn't present by lucmult · Pull Request #3177 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Fixes #3150 - Ignores resource key when it isn't present - #3177

Merged
lukesneeringer merged 3 commits into
googleapis:masterfrom
lucmult:noresource
Mar 21, 2017
ConversationCommits (3)ChecksFiles changed
Merged

Fixes #3150 - Ignores resource key when it isn't present#3177
lukesneeringer merged 3 commits into
googleapis:masterfrom
lucmult:noresource

Conversation

lucmult commented Mar 21, 2017

Copy link
Copy Markdown
Contributor
  • The new test fails with the KeyError experienced by customer.
  • Tests passing on Python 2.7 and 3.4 (I don't have 3.5 on my env).

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 21, 2017
lukesneeringer suggested changes Mar 21, 2017
View reviewed changes

lukesneeringer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

From reading #3150, am I correct that the resource key is guaranteed to be present if api_response['done'] is truthy? If so, we should move the _set_properties call into the if block rather than have the permissive try-except.

lukesneeringer commented Mar 21, 2017

Copy link
Copy Markdown
Contributor

I just confirmed that and made the change I suggested, now tossing to @dhermes for review.

CI will still fail until #3178 is merged, so it will have to go in before this can.

lukesneeringer requested a review from dhermes March 21, 2017 15:10
lukesneeringer self-assigned this Mar 21, 2017

lukesneeringer commented Mar 21, 2017

Copy link
Copy Markdown
Contributor

I merged in master (which includes #3178), merging once CI passes.

lukesneeringer merged commit 486163e into googleapis:master Mar 21, 2017
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Fixes googleapis#3150 - Ignores resource key when it isn't present (g…
4a422f3 
…oogleapis#3177)
parthea pushed a commit that referenced this pull request Mar 9, 2026
Fixes #3150 - Ignores resource key when it isn't present (#3177)
488771f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dhermes Awaiting requested review from dhermes
2 more reviewers
lukesneeringer lukesneeringer approved these changes
tseaver tseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

lukesneeringer

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL