Fix #151/#163: use ACL-specific endpoints where feasible for buckets and keys by tseaver · Pull Request #318 · googleapis/google-cloud-python · GitHub

Refactor lazy-handling of 'acl' and 'default_object_acl' using properties.
Fetch 'acl' and 'defaultObjectAcl' via GET to ACL-specific endpoints.
Continue to update 'acl' and 'defaultObjectAcl' via PATCH to the object's
resource (we can't do incremental updates to ACEs).

Fixes #151 and #163.

Changes Unknown when pulling e69c8fc on tseaver:151-163-use_acl_endpoints into * on GoogleCloudPlatform:master*.

The demo still runs with this branch, but it doesn't exercise the ACL stuff, which is borked. Review is OK, but I need to track that breakage down.

As of e74972d, I can now save / clear ACLs for buckets and keys.

ccf2a96 adds support for the fact that the back-end makes some bucket ACL entries "sticky" (they are preserved fter a successful PATCH with
data == {'acl': []}.

Changes Unknown when pulling ccf2a96 on tseaver:151-163-use_acl_endpoints into * on GoogleCloudPlatform:master*.

Changes Unknown when pulling c5c9246 on tseaver:151-163-use_acl_endpoints into * on GoogleCloudPlatform:master*.

Changes Unknown when pulling 89c80fa on tseaver:151-163-use_acl_endpoints into * on GoogleCloudPlatform:master*.

Changes Unknown when pulling 4dde9cb on tseaver:151-163-use_acl_endpoints into * on GoogleCloudPlatform:master*.

Changes Unknown when pulling a4bb709 on tseaver:151-163-use_acl_endpoints into * on GoogleCloudPlatform:master*.

LGTM, though if you want to raise a KeyError for uses of metadata methods for ACL stuff I'm cool with that. We could also file an issue and follow up after this PR.

'reset()' clears it, along with entities. 'add_entity()' sets it.

- Refactor lazy-handling of 'acl' and 'default_object_acl' using properties. - Fetch 'ac' and 'defaultObjectAcl' via GET to specific endpoints. - Continue to update 'acl' and 'defaultObjectAcl' via PATCH to the object's resource (we can't do incremental updates to ACEs). Fixes #163.

- Refactor lazy-handling of 'acl' using a property. - Fetch 'acl' via GET to a specific endpoint. - Continue to update 'acl' via PATCH to the object's resource (we can't do incremental updates to ACEs). Fixes #151.

Borked by dropping the 'projection' qs param to PATCH. Docs spell a default, but then note that overriding it w/ 'full' is required (and we need 'full' anyway, because we expect to read the resulting ACL back).

Source-Link: googleapis/synthtool@6ed3a83 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3abfa0f1886adaf0b83f07cb117b24a639ea1cb9cffe56d43280b977033563eb Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…track_id (#318) * chore: use gapic-generator-python 0.65.2 PiperOrigin-RevId: 444333013 Source-Link: googleapis/googleapis@f91b6cf Source-Link: googleapis/googleapis-gen@16eb360 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTZlYjM2MDk1YzI5NGU3MTJjNzRhMWJmMjM1NTA4MTdiNDIxNzRlNSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat!: field ObjectTrackingAnnotation.segment moved into oneof, added track_id PiperOrigin-RevId: 445061085 Source-Link: googleapis/googleapis@0506e19 Source-Link: googleapis/googleapis-gen@5796d51 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTc5NmQ1MTU1ZGY5YTM3OGMwZmQ4ZDk3YzA2ZjdkNzE3MDc2NTY3MCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Source-Link: googleapis/synthtool@76d5fec Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:979d9498e07c50097c1aeda937dcd32094ecc7440278a83e832b6a05602f62b6 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@c4dd595 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ce3c1686bc81145c81dd269bd12c4025c6b275b22d14641358827334fddb1d72

Source-Link: googleapis/synthtool@1b9ad76 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9db98b055a7f8bd82351238ccaacfd3cda58cdf73012ab58b8da146368330021

Source-Link: googleapis/synthtool@35e1ea8 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:73564f768388926a050a7a957650bfd1f584df6e0b3512e199a8e12d9dfc4618 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/25083af347468dd5f90f69627420f7d452b6c50e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8

* fix: proto field markdown comment for the display_name field in annotation_payload.proto to point the correct public v1/ version fix: Add back java_multiple_files option to the text_sentiment.proto to match with the previous published version of text_sentiment proto PiperOrigin-RevId: 421849336 Source-Link: googleapis/googleapis@5c24921 Source-Link: googleapis/googleapis-gen@0195e8e Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDE5NWU4ZTQ1ZjQxMjI1ZGRlMTViM2EyNGZlODllZDI3Njg2Y2I2NCJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

…318) Source-Link: googleapis/synthtool@8e55b32 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c6c965a4bf40c19011b11f87dbc801a66d3a23fbc6704102be064ef31c51f1c3

#318) committer: parthea PiperOrigin-RevId: 425964861 Source-Link: googleapis/googleapis@84b1a5a Source-Link: googleapis/googleapis-gen@4fb761b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGZiNzYxYmJkODUwNmFjMTU2ZjQ5YmFjNWYxODMwNmFhOGViM2FhOCJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* fix: Add async context manager return types chore: Mock return_value should not populate oneof message fields chore: Support snippet generation for services that only support REST transport chore: Update gapic-generator-python to v1.11.0 PiperOrigin-RevId: 545430278 Source-Link: googleapis/googleapis@601b532 Source-Link: googleapis/googleapis-gen@b3f18d0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* BUG: use original schema when appending Don't overwrite table schema when appending to an existing table * python 3.5 doesn't support f-string * cln: refactor `to_gbq` to avoid unnecessary extra table GET HTTP calls pandas-gbq already gets the table metadata when checking if a table exists. This refactoring avoids extra calls to get the table metadata when checking the schema. also, fix a bug where update_schema appends columns that aren't in the dataframe to the schema sent in the API request * doc: add fix to changelog * doc: revert accidental whitespace change Co-authored-by: Tim Swast <swast@google.com>

There is [an issue](https://github.com/googleapis/python-bigtable/blob/master/owlbot.py#L33) in the `owlbot.py` file added in #313 in that [s.remove_staging_dirs()](https://github.com/googleapis/synthtool/blob/master/synthtool/transforms.py#L309) should only be called once after all the files are copied over. [get_staging_dirs()](https://github.com/googleapis/synthtool/blob/master/synthtool/transforms.py#L280) will only return staging directories that exist.

…stalled (#318) Co-authored-by: Victor Chudnovsky <vchudnov@google.com>

Create wrapped Protos in two stages: 1) Load messages and enums 2) Load services and methods This allows methods to reference _all_ messages in the entire API surface without having to rely on explicit imports. This is a workaround for a common case of #318 where an LRO response or metadata type is referenced as a string in the method annotation but is not a visible, imported type.

* chore(python): Add Python 3.12 Source-Link: googleapis/synthtool@af16e6d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bacc3af03bff793a03add584537b36b5644342931ad989e3ba1171d3bd5399f5 * update common files to include python 3.12 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix typo * fix typo * add constraints file --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

…essage (#318) * Exclude function target from retry deadline exceeded exception message * apply similar patch in retry_async.py Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore: release 2.4.0 * chore: delete #318 from log (already released) * Update changelog to include published versions * insert newline in changelog * insert newline in changelog Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

🤖 I have created a release \*beep\* \*boop\* --- ## [1.2.0](https://www.github.com/googleapis/python-bigquery-sqlalchemy/compare/v1.1.0...v1.2.0) (2021-09-09) ### Features * STRUCT and ARRAY support ([#318](https://www.github.com/googleapis/python-bigquery-sqlalchemy/issues/318)) ([6624b10](https://www.github.com/googleapis/python-bigquery-sqlalchemy/commit/6624b10ded73bbca6f40af73aaeaceb95c381b63)) ### Bug Fixes * the unnest function lost needed type information ([#298](https://www.github.com/googleapis/python-bigquery-sqlalchemy/issues/298)) ([1233182](https://www.github.com/googleapis/python-bigquery-sqlalchemy/commit/123318269876e7f76c7f0f2daa5f5b365026cd3f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Fixes #318.

#421) [`google.auth.transport.Request`](https://google-auth.readthedocs.io/en/latest/reference/google.auth.transport.html#google.auth.transport.Request) says that the body should be of type bytes. Some of our code was passing in strings as reported in #318. In practice this was not causing issues, as the two http transports [requests](https://google-auth.readthedocs.io/en/latest/reference/google.auth.transport.requests.html) and [urllib3](https://google-auth.readthedocs.io/en/latest/reference/google.auth.transport.urllib3.html) are able to handle bodies passed as strings.

PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620 <details><summary>google-cloud-runtimeconfig: 0.36.0</summary> ## [0.36.0](googleapis/python-runtimeconfig@v0.35.0...v0.36.0) (2025-12-15) ### Features * Add Python 3.14 support (#327) ([6838b246](googleapis/python-runtimeconfig@6838b246)) ### Bug Fixes * resolve issues where pre-release versions of dependencies are installed (#318) ([14337044](googleapis/python-runtimeconfig@14337044)) * remove setup.cfg configuration for creating universal wheels (#321) ([922db8ce](googleapis/python-runtimeconfig@922db8ce)) </details>

fixes #318

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

tseaver added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: storage Issues related to the Cloud Storage API. labels Oct 31, 2014

tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 31, 2014

dhermes reviewed Oct 31, 2014
View reviewed changes

Comment thread gcloud/storage/bucket.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes reviewed Oct 31, 2014
View reviewed changes

Comment thread gcloud/storage/bucket.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This was referenced Oct 31, 2014

Move ACL-related APIs for buckets/keys to the relevant ACL classes. #324

Closed

Move duplicate ACL/metadata code in storage key/bucket into a subclass #262

Closed

Fix #324: Move ACL back-end manipulations from bucket / key to acl objects #326

Merged

dhermes reviewed Oct 31, 2014
View reviewed changes

Comment thread gcloud/storage/bucket.py Outdated

This comment was marked as spam.

Sign in to view

tseaver added 6 commits October 31, 2014 21:36

Allow clearing an ACL.

7f4fe7c

Add a 'loaded' flag to ACLs.

2d89c38

'reset()' clears it, along with entities. 'add_entity()' sets it.

Neaten.

b524729

Use ACL-specific endpoints where feasible for keys.

de2ad66

- Refactor lazy-handling of 'acl' using a property. - Fetch 'acl' via GET to a specific endpoint. - Continue to update 'acl' via PATCH to the object's resource (we can't do incremental updates to ACEs). Fixes #151.

Fix save/clear ACL operations.

b7d2feb

Borked by dropping the 'projection' qs param to PATCH. Docs spell a default, but then note that overriding it w/ 'full' is required (and we need 'full' anyway, because we expect to read the resulting ACL back).

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-storage to v2 (#318 )

348120b

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(main): release 0.14.1 (#318 )

ccd7be0

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea added a commit that referenced this pull request Nov 24, 2025

fix: resolve issues where pre-release versions of dependencies are in…

7aff909

…stalled (#318) Co-authored-by: Victor Chudnovsky <vchudnov@google.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025

feat: STRUCT and ARRAY support (#318 )

306bc41

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore(deps): update all dependencies (#318 )

4a2598a

parthea added a commit that referenced this pull request Nov 24, 2025

fix(deps): require protobuf <4.0.0dev (#318 )

a461839

parthea pushed a commit that referenced this pull request Nov 24, 2025

fix: use multiple batches of limited size for large operations (#321 )

39080d7

Fixes #318.

parthea pushed a commit that referenced this pull request Mar 6, 2026

ci: add backends tests

06ec8c4

fixes #318

parthea pushed a commit that referenced this pull request Mar 9, 2026

chore(main): release 1.6.0 (#318 )

c9258ff

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Mar 9, 2026

chore(revert): revert preventing normalization (#318 )

122500f

Fix #151/#163: use ACL-specific endpoints where feasible for buckets and keys by tseaver · Pull Request #318 · googleapis/google-cloud-python · GitHub

Uh oh!

Fix #151/#163: use ACL-specific endpoints where feasible for buckets and keys - #318

Fix #151/#163: use ACL-specific endpoints where feasible for buckets and keys#318tseaver merged 14 commits intogoogleapis:mastergoogleapis/google-cloud-python:masterfrom tseaver:151-163-use_acl_endpointsCopy head branch name to clipboard

Conversation

tseaver commented Oct 31, 2014

Uh oh!

coveralls commented Oct 31, 2014

Uh oh!

tseaver commented Oct 31, 2014

Uh oh!

tseaver commented Oct 31, 2014

Uh oh!

coveralls commented Oct 31, 2014

Uh oh!

coveralls commented Oct 31, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Oct 31, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Oct 31, 2014

Uh oh!

coveralls commented Oct 31, 2014

Uh oh!

coveralls commented Oct 31, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Oct 31, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix #151/#163: use ACL-specific endpoints where feasible for buckets and keys#318
tseaver merged 14 commits into
googleapis:masterfrom
tseaver:151-163-use_acl_endpoints