FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix storage encryption example, remove policy document example. by daspecster · Pull Request #3221 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Fix storage encryption example, remove policy document example. - #3221

Merged
lukesneeringer merged 1 commit into
googleapis:masterfrom
daspecster:update-storage-snippets
Mar 28, 2017
ConversationCommits (1)ChecksFiles changed
Merged

Fix storage encryption example, remove policy document example.#3221
lukesneeringer merged 1 commit into
googleapis:masterfrom
daspecster:update-storage-snippets

Conversation

daspecster commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

This removes the policy document example. I'm not sure why it's failing at the moment.

Also adds a line to the encryption key example to make it work out of the box.

daspecster added api: storage Issues related to the Cloud Storage API. docs labels Mar 28, 2017
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2017
daspecster mentioned this pull request Mar 28, 2017
Closed
24 tasks
dhermes reviewed Mar 28, 2017
View reviewed changes

dhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You should ask @jonparrott to help with the failure. Removing the example doesn't stop the feature from being broken?

Comment thread docs/storage_snippets.py Outdated
bucket = client.get_bucket('my-bucket')
assert isinstance(bucket.list_blobs(), list)
blobs = list(bucket.list_blobs())
assert isinstance(blobs, list)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

daspecster commented Mar 28, 2017

Copy link
Copy Markdown
Contributor Author

@dhermes #3172 (comment)

dhermes commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

@daspecster I saw his comment, but didn't interpret it as "I give up forever"

daspecster commented Mar 28, 2017

Copy link
Copy Markdown
Contributor Author

@dhermes sorry, I'm just trying to get through all this before the GA so there's at least a record of things that may be broken.

I may have taken @lukesneeringer's comment in the meeting about removing examples to far in this case?

daspecster added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 28, 2017

daspecster commented Mar 28, 2017

Copy link
Copy Markdown
Contributor Author

Added "do not merge" label until #3222 is figured out.

dhermes commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

@daspecster You can just restore that example so you don't need to block this PR, then settle what is to be settled in #3222

daspecster commented Mar 28, 2017

Copy link
Copy Markdown
Contributor Author

@dhermes restored!

daspecster force-pushed the update-storage-snippets branch from 1e10d2a to 358bf5f Compare March 28, 2017 17:14

lukesneeringer commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

I may have taken @lukesneeringer's comment in the meeting about removing examples to far in this case?

No, you were right. If we cannot fix the code in time, I would prefer remove the example. No example (and an issue to fix the bug) is better than an example that fails.

daspecster commented Mar 28, 2017

Copy link
Copy Markdown
Contributor Author

@lukesneeringer ok I'll rebase the last commit out and then we should be good on this one?

daspecster force-pushed the update-storage-snippets branch from 358bf5f to 3f7c92e Compare March 28, 2017 17:30

lukesneeringer commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

Yes, with the caveat that definitely make an effort to fix the bug. :-)

lukesneeringer merged commit 081f93a into googleapis:master Mar 28, 2017
daspecster removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 28, 2017
daspecster deleted the update-storage-snippets branch March 28, 2017 21:39
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Fix encryption example, remove document policy example. (googleapis#3221
affdd28 
)
parthea pushed a commit that referenced this pull request Mar 9, 2026
Fix encryption example, remove document policy example. (#3221)
61a0b3f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
tseaver tseaver left review comments
dhermes dhermes left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

lukesneeringer

tseaver

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL