FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Refactoring duplicate code between storage.key and storage.bucket. by dhermes · Pull Request #333 · googleapis/google-cloud-python · GitHub

Refactoring duplicate code between storage.key and storage.bucket. - #333

Merged
dhermes merged 3 commits into
googleapis:masterfrom
dhermes:refactor-key-bucket-shared-code
Nov 4, 2014
Merged

Refactoring duplicate code between storage.key and storage.bucket.#333
dhermes merged 3 commits into
googleapis:masterfrom
dhermes:refactor-key-bucket-shared-code

Conversation

dhermes commented Nov 3, 2014

Copy link
Copy Markdown
Contributor

@tseaver We discussed this waaaay back in #238.

Let me know how much of the tests you want me to move from Bucket / Key specific stuff into test__helpers.

Copy link
Copy Markdown

Coverage remained the same when pulling c3c9151 on dhermes:refactor-key-bucket-shared-code into 2b73c7b on GoogleCloudPlatform:master.

dhermes added api: storage Issues related to the Cloud Storage API. hygiene labels Nov 4, 2014
Comment thread gcloud/storage/_helpers.py Outdated

This comment was marked as spam.

This comment was marked as spam.

dhermes force-pushed the refactor-key-bucket-shared-code branch from c3c9151 to 2a1ab17 Compare November 4, 2014 18:14

Copy link
Copy Markdown

Coverage remained the same when pulling 2a1ab17 on dhermes:refactor-key-bucket-shared-code into abe3d7c on GoogleCloudPlatform:master.

dhermes commented Nov 4, 2014

Copy link
Copy Markdown
Contributor Author

@tseaver can I take your comment:

We can go ahead and merge this PR without waiting for those issues to land.

as an LGTM?

tseaver commented Nov 4, 2014

Copy link
Copy Markdown
Contributor

@dhermes Yup.

dhermes added a commit that referenced this pull request Nov 4, 2014
Refactoring duplicate code between storage.key and storage.bucket.
dhermes merged commit a410c6a into googleapis:master Nov 4, 2014
dhermes deleted the refactor-key-bucket-shared-code branch November 4, 2014 18:35
urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020
fixed missing parentheses which throws an error when using default parameters
parthea added a commit that referenced this pull request Jun 4, 2023
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
Source-Link: googleapis/synthtool@993985f
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1894490910e891a385484514b22eb5133578897eb5b3c380e6d8ad475c6647cd
parthea pushed a commit that referenced this pull request Jun 4, 2023
parthea added a commit that referenced this pull request Jun 4, 2023
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Jul 6, 2023
Source-Link: googleapis/synthtool@d2871d9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:b2dc5f80edcf5d4486c39068c9fa11f7f851d9568eea4dcba130f994ea9b5e97

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 20, 2023
- [ ] Regenerate this pull request now.

feat: release BatchRemoveCatalogAttributes API to v2beta version
feat: release ExactSearchableOption for attribute config to v2beta version
feat: release diversity_type for ServingConfig in v2beta version
feat: add local inventories info to the Product resource
feat: deprecate unused page_token field of PredictionRequest in v2beta version
feat: deprecate unused facet_spec field of Control in v2beta version
docs: improve documentation of SearchRequest for Search Personalization
docs: improve documentation for Fullfillment and Inventory API in ProductService
docs: minor documentation fixes and improvements

PiperOrigin-RevId: 471846764

Source-Link: googleapis/googleapis@1513294

Source-Link: googleapis/googleapis-gen@c371ea8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzM3MWVhOGRmMmUzNDk0MDg3NWQ1MTIwMGNkNTdlMzAwYTJiYzBhOCJ9
parthea pushed a commit that referenced this pull request Sep 20, 2023
release-please Bot mentioned this pull request Sep 20, 2023
parthea pushed a commit that referenced this pull request Sep 22, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/eaef28efd179e6eeb9f4e9bf697530d074a6f3b9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f8ca7655fa8a449cadcabcbce4054f593dcbae7aeeab34aa3fcc8b5cf7a93c9e
parthea pushed a commit that referenced this pull request Sep 22, 2023
Source-Link: googleapis/synthtool@453a5d9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:81ed5ecdfc7cac5b699ba4537376f3563f6f04122c4ec9e735d3b3dc1d43dd32
parthea pushed a commit that referenced this pull request Sep 22, 2023
…CIDR assigned to dual stack clusters (#333)

* feat: Add support for viewing the subnet IPv6 CIDR and services IPv6 CIDR assigned to dual stack clusters

PiperOrigin-RevId: 502669678

Source-Link: googleapis/googleapis@1f62a66

Source-Link: googleapis/googleapis-gen@f6f86f6
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjZmODZmNjMzOGU1OTM4OTI0OWRmNWQ0MWE5ZWUzNmZiOTQxZDFhZSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Sep 22, 2023
* ci(python): run lint / unit tests / docs as GH actions

Source-Link: googleapis/synthtool@57be0cd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ed1f9983d5a935a89fe8085e8bb97d94e41015252c5b6c9771257cf8624367e6

* add commit to trigger gh actions

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
* chore: remove samples

Samples have migrated here: https://github.com/GoogleCloudPlatform/python-docs-samples/tree/main/scheduler/snippets

* chore: update README to note new sample location
parthea pushed a commit that referenced this pull request Oct 21, 2023
Source-Link: googleapis/synthtool@703554a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:94961fdc5c9ca6d13530a6a414a49d2f607203168215d074cdb0a1df9ec31c0b
parthea pushed a commit that referenced this pull request Oct 21, 2023
parthea pushed a commit that referenced this pull request Oct 21, 2023
Source-Link: googleapis/synthtool@fdba3ed
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
- [ ] Regenerate this pull request now.

fix: resolve DuplicateCredentialArgs error when using credentials_file

committer: parthea
PiperOrigin-RevId: 425964861

Source-Link: googleapis/googleapis@84b1a5a

Source-Link: googleapis/googleapis-gen@4fb761b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGZiNzYxYmJkODUwNmFjMTU2ZjQ5YmFjNWYxODMwNmFhOGViM2FhOCJ9
parthea pushed a commit that referenced this pull request Oct 21, 2023
Source-Link: googleapis/synthtool@6fab84a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:7cffbc10910c3ab1b852c05114a08d374c195a81cdec1d4a67a1d129331d0bfe

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
…thod (#333)

* feat: add account-level binding for the`RunAccessReport` method (example: /v1alpha/accounts/1234567:runAccessReport)
feat: add `GetEnhancedMeasurementSettings`, `UpdateEnhancedMeasurementSettings` methods to the Admin API v1alpha
feat: add `CreateConnectedSiteTag`, `DeleteConnectedSiteTag`, `ListConnectedSiteTags` methods to the Admin API v1alpha
feat: add `EnhancedMeasurementSettings`, `ConnectedSiteTag` resource types to the Admin API v1alpha
feat: add `GetEnhancedMeasurementSettingsRequest`,
`UpdateEnhancedMeasurementSettingsRequest`,`CreateConnectedSiteTagRequest`, `CreateConnectedSiteTagResponse`, `DeleteConnectedSiteTagRequest`, `ListConnectedSiteTagsRequest`, `ListConnectedSiteTagsResponse`
feat: add `ENHANCED_MEASUREMENT_SETTINGS` option to the `ChangeHistoryResourceType` enum
feat: add `enhanced_measurement_settings` option to the `ChangeHistoryResource.resource` oneof field
feat: add `intraday_export_enabled` field to the `BigQueryLink` resource

PiperOrigin-RevId: 518088512

Source-Link: googleapis/googleapis@061a9fb

Source-Link: googleapis/googleapis-gen@c64b9cd
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzY0YjljZDM4MDczYjIyMDJjZTZlYjA3ZDU4YzZhOGM1ODFmY2UyYyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
* chore: use gapic-generator-python 0.63.2
docs: add generated snippets

PiperOrigin-RevId: 427792504

Source-Link: googleapis/googleapis@55b9e1e

Source-Link: googleapis/googleapis-gen@bf4e86b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmY0ZTg2Yjc1M2Y0MmNiMGVkYjFmZDUxZmJlODQwZDdkYTBhMWNkZSJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 18, 2025
Use this argument to override the default ``dtype`` for a particular column in
the query results. For example, this can be used to select nullable integer
columns as the ``Int64`` nullable integer pandas extension type.

    df = gbq.read_gbq(
        "SELECT CAST(NULL AS INT64) AS null_integer",
        dtypes={"null_integer": "Int64"},
    )
parthea pushed a commit that referenced this pull request Nov 22, 2025
... chore: update gapic-generator-ruby to the latest commit chore: release gapic-generator-typescript 1.5.0

Committer: @miraleung
PiperOrigin-RevId: 380641501

Source-Link: googleapis/googleapis@076f7e9

Source-Link: googleapis/googleapis-gen@27e4c88
parthea pushed a commit that referenced this pull request Nov 24, 2025
parthea added a commit that referenced this pull request Nov 24, 2025
Source-Link: googleapis/synthtool@69fda12
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ae600f36b6bc972b368367b6f83a1d91ec2c82a4a116b383d67d547c56fe6de3

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Nov 24, 2025
* chore: use public post processor image

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
* feat(ci): Add Python 3.14 support to owlbot.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat(ci): Add Python 3.14 support to core files

* Apply suggestion from @chalmerlowe

3.7 is not supported in this repo.

* Apply suggestion from @chalmerlowe

* Apply suggestion from @chalmerlowe

3.7 is not supported in this repo.

* fix(ci): Remove unit (3.7) from required checks

* fix(coverage): Remove obsolete Python < 3.8 import logic

* fix(coverage): Add no cover pragma for api_key import

* fix(ci): Correct lint errors and coverage pragma case

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Nov 24, 2025
`setup.cfg` contains a setting to create a `Universal Wheel` which is only needed if libraries support both Python 2 and Python 3. This library only supports Python 3 so this setting is no longer needed. See https://packaging.python.org/en/latest/guides/distributing-packages-using-setuptools/#wheels.

See similar PR https://togithub.com/googleapis/google-cloud-python/pull/13659 which includes this stack trace

```
      running bdist_wheel
      /tmp/pip-build-env-9o_3w17v/overlay/lib/python3.13/site-packages/setuptools/_distutils/cmd.py:135: SetuptoolsDeprecationWarning: bdist_wheel.universal is deprecated
      !!
      
              ********************************************************************************
              With Python 2.7 end-of-life, support for building universal wheels
              (i.e., wheels that support both Python 2 and Python 3)
              is being obviated.
              Please discontinue using this option, or if you still need it,
              file an issue with pypa/setuptools describing your use case.
      
              By 2025-Aug-30, you need to update your project and remove deprecated calls
              or your builds will no longer be supported.
              ********************************************************************************
      
      !!
```
parthea pushed a commit that referenced this pull request Nov 24, 2025
- Added support for Custom Classifier entities
- Added Unit Tests for Classifier output
- Added input validation for `Document.split_pdf()`

Fixes #332 🦕
parthea pushed a commit that referenced this pull request Nov 24, 2025
Source-Link: googleapis/synthtool@b0eb8a8
Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:df50e8d462f86d6bcb42f27ecad55bb12c404f1c65de9c6fe4c4d25120080bd6
parthea pushed a commit that referenced this pull request Nov 24, 2025
This fixes a bug that caused deleting an entity inside of a transaction
to hang.

Fixes #271
parthea pushed a commit that referenced this pull request Nov 25, 2025
Source-Link: googleapis/synthtool@b0eb8a8
Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:df50e8d462f86d6bcb42f27ecad55bb12c404f1c65de9c6fe4c4d25120080bd6
parthea pushed a commit that referenced this pull request Mar 6, 2026
The tests remain commented out because issue #331 also affects them.

fixes #333
parthea pushed a commit that referenced this pull request Mar 9, 2026
parthea pushed a commit that referenced this pull request Mar 9, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL