FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

iam.Policy: return empty set on missing key. by tseaver · Pull Request #3424 · googleapis/google-cloud-python · GitHub

iam.Policy: return empty set on missing key. - #3424

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:3346-core-iam_policy_defaultdict_set
May 16, 2017
Merged

iam.Policy: return empty set on missing key.#3424
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:3346-core-iam_policy_defaultdict_set

Conversation

tseaver commented May 16, 2017

Copy link
Copy Markdown
Contributor

Closes #3346.

tseaver added auth api: core type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels May 16, 2017
tseaver requested review from dhermes and theacodes May 16, 2017 18:46
googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 16, 2017

dhermes commented May 16, 2017

Copy link
Copy Markdown
Contributor

Do we really need a defaultdict to solve #3346?

theacodes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This LGTM, but if @dhermes prefers a different approach then I defer to him.

dhermes commented May 16, 2017

Copy link
Copy Markdown
Contributor

Nah if it's OK with @jonparrott it's OK with me

tseaver merged commit 77a7fa0 into googleapis:master May 16, 2017
tseaver deleted the 3346-core-iam_policy_defaultdict_set branch May 16, 2017 20:58
parthea pushed a commit that referenced this pull request Nov 24, 2025
…t_set

iam.Policy: return empty set on missing key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: core auth cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL