Add 'Table.row_from_mapping' helper. - #3425
Merged
lukesneeringer merged 2 commits intoAug 7, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
dhermes
reviewed
May 16, 2017
dhermes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I wouldn't say this "closes #3396". That asks us to accept dictionaries in insert_data.
We should either:
- Explicitly not support it (i.e. either a blacklist or whitelist of types)
- Accept a polymorphic input (I am not really into that)
- Offer a sibling insert_data_from_mappings (or a better / shorter name)
Sorry, something went wrong.
Comment thread
bigquery/google/cloud/bigquery/table.py
|
|
||
| :rtype: tuple | ||
| :returns: Tuple matching the table's schema | ||
| :raises: ValueError if table's schema is not set |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
bigquery/google/cloud/bigquery/table.py
Outdated
| :param mapping: Mapping of row data. | ||
|
|
||
| :rtype: tuple | ||
| :returns: Tuple matching the table's schema |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
bigquery/google/cloud/bigquery/table.py
Outdated
| row.append(mapping[field.name]) | ||
| elif field.mode == 'REPEATED': | ||
| row.append(mapping.get(field.name, ())) | ||
| else: # NULLABLE |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
bigquery/google/cloud/bigquery/table.py
| row.append(mapping.get(field.name, ())) | ||
| else: # NULLABLE | ||
| row.append(mapping.get(field.name)) | ||
| return tuple(row) |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
bigquery/tests/unit/test_table.py
| with self.assertRaises(ValueError) as exc: | ||
| table.row_from_mapping(MAPPING) | ||
|
|
||
| self.assertEqual(exc.exception.args, (_TABLE_HAS_NO_SCHEMA,)) |
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
Author
|
Given a row_from_mapping helper method, the insert_data_from_mappings one is redundant: it is the equivalent of: table.insert_data([table.row_from_mapping(mapping) for mapping in mapping_list])I'm proposing closing #3396 with a note to that effect. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
If LGTY @lukesneeringer then I'm OK with it |
Sorry, something went wrong.
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3396.