Marshal row data correctly in 'Table.insert_data()' - #3426
Merged
tseaver merged 4 commits intoMay 18, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
dhermes
reviewed
May 16, 2017
Comment thread
bigquery/google/cloud/bigquery/_helpers.py
| :returns: A tuple of data converted to native types. | ||
| """ | ||
| row_data = [] | ||
| for field, cell in zip(schema, row['f']): |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
bigquery/google/cloud/bigquery/_helpers.py
Outdated
| """Convert JSON row data to rows with appropriate types.""" | ||
| return [_row_from_json(row, schema) for row in rows] | ||
| # Converters used for scalar values marshalled as query parameters. | ||
| _SCALAR_VALUE_TO_JSON_PARM = _SCALAR_VALUE_TO_JSON_ROW.copy() |
This comment was marked as spam.
Comment thread
bigquery/google/cloud/bigquery/table.py
Outdated
| # Specifies the number of seconds since the epoch. | ||
| value = _convert_timestamp(value) | ||
| converter = _SCALAR_VALUE_TO_JSON_ROW.get(field.field_type) | ||
| if converter is not None: |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
dhermes
approved these changes
May 18, 2017
dhermes
added a commit
that referenced
this pull request
Jun 2, 2017
theacodes
pushed a commit
that referenced
this pull request
Jun 2, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 more reviewers5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2957.