| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
It would be great to solve this by just consolidating ClientWithProject and ClientWithCredentials Client |
Sorry, something went wrong.
|
@jonparrott See the table I made about usage. The only issue with that is some APIs don't use a project (and we don't want to fail their constructors over a missing project). |
Sorry, something went wrong.
|
Does it help that google auth doesn't error if it can't determine a project?
|
Sorry, something went wrong.
|
@jonparrott Mostly it doesn't help because it isn't true? Or do you mean something else? |
Sorry, something went wrong.
|
That's if it doesn't find credentials, not if it doesn't find the project.
|
Sorry, something went wrong.
|
But there is no google.auth.default_project? |
Sorry, something went wrong.
|
Right. This is part of the constraint. You should never get a project ID that didn't come from the same source as the credentials.
|
Sorry, something went wrong.
|
Makes sense. @lukesneeringer WDYT of us just using project on every Client instance? (This would just bring Client and ClientWithProject together, ClientWithProject is already a tiny impl.) |
Sorry, something went wrong.
|
FTR, ClientWithProject is skipped by the following: $ for f in $(ls */google/cloud/*/client.py); do
if ! grep -q ClientWithProject $f; then
echo $f
fi
done
bigtable/google/cloud/bigtable/client.py
language/google/cloud/language/client.py
resource_manager/google/cloud/resource_manager/client.py
spanner/google/cloud/spanner/client.py
speech/google/cloud/speech/client.py
translate/google/cloud/translate/client.pyOf those, the following have _ClientProjectMixin included: $ for f in $(ls */google/cloud/*/client.py); do
if ! grep -q ClientWithProject $f; then
echo $f
fi
done | xargs grep -l _ClientProjectMixin
bigtable/google/cloud/bigtable/client.py
spanner/google/cloud/spanner/client.py |
Sorry, something went wrong.
Sorry, something went wrong.
| # Check that mocks were called as expected. | ||
| file_open.assert_called_once_with( | ||
| mock.sentinel.filename, 'r', encoding='utf-8') | ||
| constructor.assert_called_once_with(info) |
|
@tseaver Sorry I missed your LGTM 18 days ago. It's good I got this in, in case we have a google-cloud-core release for your gRPC remap PR, this can go in too. |
Sorry, something went wrong.
…rm/python-docs-samples#3436) * [container_registry] fix: fix broken test fixes #3435 * Use Pub/Sub message receiver that can notify main thread when it has received expected number of messages. * Only test one single occurence. * Use uuid4 wherever makes sense. * test if Pub/Sub client receives at least one message
| Back | FazBrowse Home | New Git URL |
Fixes #1883.
@lukesneeringer This is a long-standing bug but should really make it into a google-cloud-core release. I know you hate releasing core.