FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "Fix "broken" docs build. (#3422)" by dhermes · Pull Request #3439 · googleapis/google-cloud-python · GitHub

Revert "Fix "broken" docs build. (#3422)" - #3439

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:revert-3422
Jun 5, 2017
Merged

Revert "Fix "broken" docs build. (#3422)"#3439
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:revert-3422

Conversation

dhermes commented May 18, 2017
edited
Loading

Copy link
Copy Markdown
Contributor

This reverts commit a849060.

NOTE: This is labeled "don't merge" because the Sphinx fix hasn't been released to PyPI yet (note the change in nox.py, which is the part that shouldn't be merged).

dhermes added docs do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 18, 2017
googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 18, 2017

tseaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM modulo the not-to-be-merged changes to the root nox.py.

dhermes removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 5, 2017

dhermes commented Jun 5, 2017

Copy link
Copy Markdown
Contributor Author

@tseaver @lukesneeringer Sphinx==1.6.2 has been released so this is ready to merge.

tseaver commented Jun 5, 2017

Copy link
Copy Markdown
Contributor

Merge away when green.

dhermes merged commit 45084cf into googleapis:master Jun 5, 2017
dhermes deleted the revert-3422 branch June 5, 2017 19:40
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
parthea pushed a commit that referenced this pull request Mar 2, 2026
This reverts commit 90565b0043d40bae9eb6a2e905aa8f22c8951029.
parthea pushed a commit that referenced this pull request Mar 9, 2026
This reverts commit 60be7d68626bbd6d4396f4f94cf6b88c77d2e2ae.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL