FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add Part Of Speech missing data to Token by dvaldivia · Pull Request #3457 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Add Part Of Speech missing data to Token - #3457

Merged
tseaver merged 11 commits into
googleapis:masterfrom
dvaldivia:master
Jun 5, 2017
ConversationCommits (11)ChecksFiles changed
Merged

Add Part Of Speech missing data to Token#3457
tseaver merged 11 commits into
googleapis:masterfrom
dvaldivia:master

Conversation

dvaldivia commented May 29, 2017

Copy link
Copy Markdown
Contributor

Hi,

This PR add the missing data returned by the API to the Token, before only the Tag was being returned, I added all the data to the existing PartOfSpeech object and replaced it's hydratation on the Token as well

googlebot commented May 29, 2017

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 29, 2017

dvaldivia commented May 29, 2017

Copy link
Copy Markdown
Contributor Author

I signed it!

googlebot commented May 29, 2017

Copy link
Copy Markdown

CLAs look good, thanks!

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 29, 2017
lukesneeringer approved these changes May 30, 2017
View reviewed changes

lukesneeringer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks good to me. (Thanks for all your work, @dvaldivia!)

dvaldivia commented May 30, 2017

Copy link
Copy Markdown
Contributor Author

@lukesneeringer you are welcome :) What's next? Do I need to do anything else?

dhermes reviewed May 31, 2017
View reviewed changes
Comment thread language/google/cloud/language/syntax.py Outdated
class PartOfSpeech(object):
"""Part of speech of a :class:`Token`."""
"""A Google Cloud Natural Language API Part of speech object.
Rich data about the Part of Speech of a token returned by the API

This comment was marked as spam.

Sign in to view

dhermes reviewed May 31, 2017
View reviewed changes
Comment thread language/tests/unit/test_api_responses.py

from copy import copy
import unittest
from copy import copy

This comment was marked as spam.

Sign in to view

dvaldivia commented May 31, 2017

Copy link
Copy Markdown
Contributor Author

@dhermes did as you requested, let me know if I should change anything else.

tseaver added the api: language Issues related to the Cloud Natural Language API API. label Jun 5, 2017
tseaver merged commit b0abcb2 into googleapis:master Jun 5, 2017
dhermes mentioned this pull request Jun 5, 2017
Merged
This was referenced Jun 26, 2017
Merged
Closed
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
Add Part Of Speech missing data to Token (googleapis#3457)
eb5ae18 
Add support for all the data returned by the API for PartOfSpeech inside Token.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Add Part Of Speech missing data to Token (googleapis#3457)
3c7a76d 
Add support for all the data returned by the API for PartOfSpeech inside Token.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Add Part Of Speech missing data to Token (googleapis#3457)
db38de0 
Add support for all the data returned by the API for PartOfSpeech inside Token.
parthea pushed a commit that referenced this pull request Jul 6, 2023
Add Part Of Speech missing data to Token (#3457)
f4d9b1b 
Add support for all the data returned by the API for PartOfSpeech inside Token.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
dhermes dhermes left review comments
lukesneeringer lukesneeringer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: language Issues related to the Cloud Natural Language API API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL