Add 'Bucket.labels' property. - #3478
Merged
tseaver merged 2 commits intoJun 6, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
dhermes
approved these changes
Jun 6, 2017
dhermes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM pending nits
Sorry, something went wrong.
Comment thread
storage/google/cloud/storage/bucket.py
|
|
||
| :setter: Set labels for this bucket. | ||
| :getter: Gets the labels for this bucket. | ||
|
|
This comment was marked as spam.
Comment thread
storage/tests/unit/test_blob.py
| blob = self._make_one(blob_name, bucket=None) | ||
| unicode_name = u'wet \N{sailboat}' | ||
| self.assertNotEqual(blob.name, blob_name) | ||
| self.assertNotIsInstance(blob.name, bytes) |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
storage/tests/unit/test_blob.py
Outdated
| unicode_name = u'wet \N{sailboat}' | ||
| self.assertNotEqual(blob.name, blob_name) | ||
| self.assertNotIsInstance(blob.name, bytes) | ||
| self.assertIsInstance(blob.name, type(unicode_name)) |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
storage/tests/unit/test_bucket.py
Outdated
| self.assertEqual(bucket.labels, {}) | ||
| bucket.labels = LABELS | ||
| self.assertEqual(bucket.labels, LABELS) | ||
| self.assertTrue('labels' in bucket._changes) |
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
Author
|
I will merge when CI is green. |
Sorry, something went wrong.
dhermes
reviewed
Jun 6, 2017
Comment thread
storage/tests/unit/test_bucket.py
Outdated
| self.assertEqual(bucket.labels, {}) | ||
| bucket.labels = LABELS | ||
| self.assertEqual(bucket.labels, LABELS) | ||
| self.assertIsNot(bucket.labels, LABELS) |
This comment was marked as spam.
This comment was marked as spam.
This was referenced Jun 26, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
* Avoid UnicodeWarning reported by new py.test * Add 'Bucket.labels' property. See: https://cloud.google.com/storage/docs/json_api/v1/buckets#labels Closes googleapis#3473.
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
* Avoid UnicodeWarning reported by new py.test * Add 'Bucket.labels' property. See: https://cloud.google.com/storage/docs/json_api/v1/buckets#labels Closes googleapis#3473.
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
* Avoid UnicodeWarning reported by new py.test * Add 'Bucket.labels' property. See: https://cloud.google.com/storage/docs/json_api/v1/buckets#labels Closes googleapis#3473.
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
…/python-docs-samples#3478) Use new effective_severity field fixes b/142836422
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
* Avoid UnicodeWarning reported by new py.test * Add 'Bucket.labels' property. See: https://cloud.google.com/storage/docs/json_api/v1/buckets#labels Closes #3473.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://cloud.google.com/storage/docs/json_api/v1/buckets#labels
Closes #3473.