Add '{Bucket,Blob}.user_project' properties. - #3490
Merged
tseaver merged 9 commits intoJun 13, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This was referenced Jun 8, 2017
Save and expose via read-only 'user_project' property.
Copy link
Copy Markdown
Contributor
Author
|
Rebased against master after the merge of #3488. |
Sorry, something went wrong.
dhermes
reviewed
Jun 12, 2017
dhermes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pretty straightforward, mostly (totally?) just nits
Sorry, something went wrong.
Comment thread
storage/google/cloud/storage/_helpers.py
| # Pass only '?projection=noAcl' here because 'acl' and related | ||
| # are handled via custom endpoints. | ||
| query_params = {'projection': 'noAcl'} | ||
| if self.user_project is not None: |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
storage/google/cloud/storage/blob.py
| @property | ||
| def user_project(self): | ||
| """Project ID used for API requests made via this blob. | ||
|
|
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
storage/google/cloud/storage/bucket.py
Outdated
|
|
||
| :type user_project: str | ||
| :param user_project: (Optional) the project ID to be billed for API | ||
| requests made via this instance. |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
storage/google/cloud/storage/bucket.py
| def user_project(self): | ||
| """Project ID to be billed for API requests made via this bucket. | ||
|
|
||
| If unset, API requests are billed to the bucket owner. |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
storage/tests/unit/test__helpers.py
| mixin = self._make_one() | ||
| self.assertRaises(NotImplementedError, lambda: mixin.path) | ||
| with self.assertRaises(NotImplementedError): | ||
| mixin.path |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
storage/tests/unit/test__helpers.py
Outdated
| connection = _Connection({'foo': 'Foo'}) | ||
| client = _Client(connection) | ||
| derived = self._derivedClass('/path', user_project)() | ||
| # Make sure changes is not a set, so we can observe a change. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
storage/tests/unit/test__helpers.py
Outdated
| self.assertEqual(kw[0]['path'], '/path') | ||
| self.assertEqual( | ||
| kw[0]['query_params'], | ||
| {'projection': 'noAcl', 'userProject': user_project}) |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
storage/tests/unit/test_bucket.py
| bucket = klass(client, name=NAME, user_project=USER_PROJECT) | ||
| self.assertEqual(bucket.name, NAME) | ||
| self.assertEqual(bucket._properties, {}) | ||
| self.assertEqual(bucket.user_project, USER_PROJECT) |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
storage/tests/unit/test__helpers.py
Outdated
| kw[0]['query_params'], | ||
| {'projection': 'full', 'userProject': user_project}) | ||
| # Since changes does not include `baz`, we don't see it sent. | ||
| self.assertEqual(kw[0]['data'], {'bar': BAR}) |
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
|
LGTM after your comment update |
Sorry, something went wrong.
tseaver
deleted the
3474-storage-bucket-requester_pays-user_project-property
branch
June 13, 2017 13:55
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
* Add abstract '_PropertyMixin.user_project' property.
* Support 'user_project' in '_PropertyMixin.{reload,patch}'.
* Add 'user_project' param to 'Bucket.__init__'.
* Save and expose via read-only 'user_project' property.
* Implement 'Blob.user_property' via bucket's value.
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
* Add abstract '_PropertyMixin.user_project' property.
* Support 'user_project' in '_PropertyMixin.{reload,patch}'.
* Add 'user_project' param to 'Bucket.__init__'.
* Save and expose via read-only 'user_project' property.
* Implement 'Blob.user_property' via bucket's value.
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
* Add abstract '_PropertyMixin.user_project' property.
* Support 'user_project' in '_PropertyMixin.{reload,patch}'.
* Add 'user_project' param to 'Bucket.__init__'.
* Save and expose via read-only 'user_project' property.
* Implement 'Blob.user_property' via bucket's value.
tseaver
added a commit
that referenced
this pull request
Sep 22, 2017
* Add abstract '_PropertyMixin.user_project' property.
* Support 'user_project' in '_PropertyMixin.{reload,patch}'.
* Add 'user_project' param to 'Bucket.__init__'.
* Save and expose via read-only 'user_project' property.
* Implement 'Blob.user_property' via bucket's value.
tseaver
added a commit
that referenced
this pull request
Oct 2, 2017
* Add abstract '_PropertyMixin.user_project' property.
* Support 'user_project' in '_PropertyMixin.{reload,patch}'.
* Add 'user_project' param to 'Bucket.__init__'.
* Save and expose via read-only 'user_project' property.
* Implement 'Blob.user_property' via bucket's value.
tseaver
added a commit
that referenced
this pull request
Oct 5, 2017
* Add abstract '_PropertyMixin.user_project' property.
* Support 'user_project' in '_PropertyMixin.{reload,patch}'.
* Add 'user_project' param to 'Bucket.__init__'.
* Save and expose via read-only 'user_project' property.
* Implement 'Blob.user_property' via bucket's value.
tseaver
added a commit
that referenced
this pull request
Oct 10, 2017
* Add abstract '_PropertyMixin.user_project' property.
* Support 'user_project' in '_PropertyMixin.{reload,patch}'.
* Add 'user_project' param to 'Bucket.__init__'.
* Save and expose via read-only 'user_project' property.
* Implement 'Blob.user_property' via bucket's value.
tseaver
added a commit
that referenced
this pull request
Oct 10, 2017
* Add abstract '_PropertyMixin.user_project' property.
* Support 'user_project' in '_PropertyMixin.{reload,patch}'.
* Add 'user_project' param to 'Bucket.__init__'.
* Save and expose via read-only 'user_project' property.
* Implement 'Blob.user_property' via bucket's value.
vchudnov-g
pushed a commit
that referenced
this pull request
Sep 20, 2023
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
* Add abstract '_PropertyMixin.user_project' property.
* Support 'user_project' in '_PropertyMixin.{reload,patch}'.
* Add 'user_project' param to 'Bucket.__init__'.
* Save and expose via read-only 'user_project' property.
* Implement 'Blob.user_property' via bucket's value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses #3489 as a base.