FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Prep runtimeconfig-0.25.0 release. by tseaver · Pull Request #3545 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Prep runtimeconfig-0.25.0 release. - #3545

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:runtimeconfig-0.25.0-prep
Jun 26, 2017
ConversationCommits (1)ChecksFiles changed
Merged

Prep runtimeconfig-0.25.0 release.#3545
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:runtimeconfig-0.25.0-prep

Conversation

tseaver commented Jun 26, 2017 •
edited by dhermes
Loading

Copy link
Copy Markdown
Contributor

Requires merge of #3526 to bump core to 0.25.0.

Draft release notes:

google-cloud-runtimeconfig-0.25.0

  • Update google-cloud-core dependency to ~= 0.25.

Excluded from notes:

tseaver added api: runtimeconfig Issues related to the Cloud Runtime Config API API. packaging labels Jun 26, 2017
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2017
tseaver mentioned this pull request Jun 26, 2017
Closed
18 tasks

dhermes commented Jun 26, 2017

Copy link
Copy Markdown
Contributor

@tseaver I'm not sure about the use of ~ (I presume to mean approximately?) How about instead:

Update google-cloud-core dependency to 0.25.x series?

tseaver commented Jun 26, 2017

Copy link
Copy Markdown
Contributor Author

I meant to be using ~=, in the PEP 440 sense.

dhermes commented Jun 26, 2017

Copy link
Copy Markdown
Contributor

I'm not sure many people know ~= in the PEP 440 sense. I've read PEP 440 and I don't.

tseaver commented Jun 26, 2017

Copy link
Copy Markdown
Contributor Author

AFAIK, it is what we should be using rather than the incantation we are now.

tseaver commented Jun 26, 2017

Copy link
Copy Markdown
Contributor Author 
$ /opt/Python-2.7.13/bin/virtualenv /tmp/pep440
New python executable in /tmp/pep440/bin/python
Installing setuptools, pip, wheel...done.
$ /tmp/pep440/bin/pip install google-cloud-core~=0.24
Collecting google-cloud-core~=0.24
  Using cached google_cloud_core-0.24.1-py2.py3-none-any.whl
...

dhermes approved these changes Jun 26, 2017
View reviewed changes

dhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

dhermes commented Jun 26, 2017

Copy link
Copy Markdown
Contributor

I'm not sure we're using it anywhere? Or do you mean rather than the lower-upper bound combination?

tseaver merged commit 0ac5a24 into googleapis:master Jun 26, 2017
tseaver deleted the runtimeconfig-0.25.0-prep branch June 26, 2017 22:51
tseaver added a commit that referenced this pull request Jul 10, 2017
Prep runtimeconfig-0.25.0 release. (#3545)
8d6b30a
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
Prep runtimeconfig-0.25.0 release. (googleapis#3545)
b168021
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Prep runtimeconfig-0.25.0 release. (googleapis#3545)
b25ed3f
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Prep runtimeconfig-0.25.0 release. (googleapis#3545)
b2e1998
parthea pushed a commit that referenced this pull request Nov 24, 2025
Prep runtimeconfig-0.25.0 release. (#3545)
3a153f0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lukesneeringer Awaiting requested review from lukesneeringer
1 more reviewer
dhermes dhermes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: runtimeconfig Issues related to the Cloud Runtime Config API API. cla: yes This human has signed the Contributor License Agreement. packaging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL