NL GAPIC Shim - #3590
Merged
lukesneeringer merged 6 commits intoJul 26, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@lukesneeringer What in particular would you like reviewed? |
Sorry, something went wrong.
added 2 commits
July 7, 2017 10:39
Copy link
Copy Markdown
Contributor
Author
|
@dhermes Sanity check mostly. |
Sorry, something went wrong.
dhermes
reviewed
Jul 10, 2017
Comment thread
docs/vision/index.rst
| gapic/api | ||
| gapic/types | ||
| gapic/v1/api | ||
| gapic/v1/types |
This comment was marked as spam.
Comment thread
language/google/cloud/language_v1/types.py
| for name, message in get_messages(language_service_pb2).items(): | ||
| message.__module__ = 'google.cloud.language_v1.types' | ||
| setattr(sys.modules[__name__], name, message) | ||
| names.append(name) |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
language/setup.py
| SETUP_BASE = { | ||
| 'author': 'Google Cloud Platform', | ||
| 'author_email': 'jjg+google-cloud-python@google.com', | ||
| 'author_email': 'googleapis-publisher@google.com', |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
language/tests/gapic/v1/language_service_smoke_test.py
| @@ -0,0 +1,30 @@ | |||
| # Copyright 2017, Google Inc. All rights reserved. | |||
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
language/tests/gapic/v1/test_language_service_client_v1.py
| # limitations under the License. | ||
| """Unit tests.""" | ||
|
|
||
| import mock |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
language/tests/gapic/v1/test_language_service_client_v1.py
| from google.cloud.proto.language.v1 import language_service_pb2 | ||
|
|
||
|
|
||
| class CustomException(Exception): |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
vision/setup.py
| REQUIREMENTS = [ | ||
| 'google-cloud-core >= 0.25.0, < 0.26dev', | ||
| 'google-gax >= 0.15.7, < 0.16dev', | ||
| 'google-gax >= 0.15.13, < 0.16dev', |
This comment was marked as spam.
lukesneeringer
commented
Jul 11, 2017
Comment thread
language/tests/gapic/v1/test_language_service_client_v1.py
| document=document, encoding_type=encoding_type) | ||
| self.assertEqual(expected_request, actual_request) | ||
|
|
||
| @mock.patch('google.gax.config.API_ERRORS', (CustomException, )) |
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
Author
|
Merging this despite the PubSub Circle failure (which is unrelated). |
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the manual code and documentation to augment moving Natural Language to GAPIC only.
Using nl-gapic as a base branch so reviewers do not have to look at the auto-gen.