Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
• In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

I signed!

CLAs look good, thanks!

I was a bit confused by what is needed, but this example clarifies for me:

>>> class A(object):
...     def __init__(self, val):
...         self.val = val
...     def __repr__(self):
...         return 'A({!r})'.format(self.val)
...     def __eq__(self, other):
...         if not isinstance(other, A):
...             return NotImplemented
...         return other.val == self.val
...     def __ne__(self, other):
...         if not isinstance(other, A):
...             return NotImplemented
...         return other.val != self.val
...
>>> a1 = A(10)
>>> a2 = A(11)
>>> a3 = A(11)
>>> a1 == a2
False
>>> a1 == a3
False
>>> a2 == a3
True
>>> set([a1, a2, a3])
set([A(10), A(11), A(11)])

@dhermes @tseaver what do you think of this?

@dhermes @tseaver i modified the default arg for fields to be (). The question is what to do with how this resource is represented. Should I use () there too? This is what I did, so if you would rather have me use [] I can change that.

FYI: this broke a few tests and I'm wondering if it will break any of the actual api calls.

Hmm looks like I broke some tests in circleci, let me go fix that

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@azymnis We (@jonparrott, @lukesneeringer and I) just had a discussion about this and determined SchemaField should be immutable in order to be hashable.

Rather than put the burden on you, I have sent a commit into this PR to make the class immutable.

@dhermes makes sense, thanks for the update

Thank you all!