Add base future package to google.cloud - #3616
Merged
theacodes merged 5 commits intoJul 17, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
added 2 commits
July 17, 2017 11:12
dhermes
reviewed
Jul 17, 2017
Comment thread
core/google/cloud/_helpers.py
| raise ValueError('%r could not be converted to unicode' % (value,)) | ||
|
|
||
|
|
||
| def _from_any_pb(pb_type, any_pb): |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
core/google/cloud/_helpers.py
| any_pb (google.protobuf.any_pb2.Any): the object to be converted. | ||
|
|
||
| Returns: | ||
| pb_type: An instance of the pb_type message. |
This comment was marked as spam.
Comment thread
core/google/cloud/future/__init__.py
| @@ -0,0 +1,21 @@ | |||
| # Copyright 2017, Google Inc. | |||
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
core/google/cloud/future/base.py
Outdated
| """ | ||
|
|
||
| @abc.abstractmethod | ||
| def cancel(self): # pragma: NO COVER |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
core/google/cloud/future/base.py
Outdated
|
|
||
| @six.add_metaclass(abc.ABCMeta) | ||
| class Future(object): | ||
| # pylint: disable=missing-docstring, invalid-name |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
core/tests/unit/future/test__helpers.py
| @@ -0,0 +1,52 @@ | |||
| # Copyright 2017, Google Inc. | |||
This comment was marked as spam.
This comment was marked as spam.
added 2 commits
July 17, 2017 12:47
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
duggelz
reviewed
Jul 17, 2017
Comment thread
core/google/cloud/future/base.py
|
|
||
| """Future interface. | ||
|
|
||
| This interface is based on :class:`concurrent.futures.Future`. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.