Update bigtable to use operation.future - #3623
Merged
theacodes merged 1 commit intoJul 20, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
theacodes
force-pushed
the
bigtable-future
branch
from
ce42385 to
0858e11
Compare
July 19, 2017 16:42
Copy link
Copy Markdown
Contributor
Author
|
@dhermes @lukesneeringer this is ready for review. |
Sorry, something went wrong.
dhermes
reviewed
Jul 20, 2017
dhermes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM though I have two concerns:
- I wish you'd separate the bugfix in _prepare_create_request (where you add location to the request payload) into a new PR
- It'd be nice to get CircleCI green, especially for these system tests with the changes (have you run them?)
Sorry, something went wrong.
Comment thread
bigtable/google/cloud/bigtable/cluster.py
Outdated
| cluster=data_v2_pb2.Cluster( | ||
| serve_nodes=cluster.serve_nodes, | ||
| location=cluster.location, | ||
| serve_nodes=cluster.serve_nodes |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
bigtable/tests/system.py
| IN_EMULATOR = False | ||
|
|
||
|
|
||
| def _wait_until_complete(operation, max_attempts=5): |
This comment was marked as spam.
theacodes
force-pushed
the
bigtable-future
branch
from
0858e11 to
2442002
Compare
July 20, 2017 17:21
theacodes
force-pushed
the
bigtable-future
branch
from
2442002 to
2540600
Compare
July 20, 2017 17:46
Copy link
Copy Markdown
Contributor
Author
|
Rebased, will merge when CI is green. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
😀 Yay! |
Sorry, something went wrong.
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
parthea
pushed a commit
that referenced
this pull request
Nov 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3617
NOTE: This is a breaking change. Bigtable previously returned google.cloud.operation instances from long-running operations, it now returns google.cloud.future.operation instances.