Remove references to google.cloud.operation from spanner - #3625
Merged
theacodes merged 2 commits intoJul 20, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
theacodes
force-pushed
the
spanner-future
branch
from
0f65187 to
6d26cf9
Compare
July 19, 2017 16:57
Copy link
Copy Markdown
Contributor
Author
|
@dhermes @lukesneeringer this is ready for review. |
Sorry, something went wrong.
dhermes
approved these changes
Jul 20, 2017
dhermes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM I'm amazed this PR was so easy.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Same. Will merge when CI is green. |
Sorry, something went wrong.
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
…3625) * Remove references to google.cloud.operation from spanner * Remove unused import
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
…3625) * Remove references to google.cloud.operation from spanner * Remove unused import
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
…3625) * Remove references to google.cloud.operation from spanner * Remove unused import
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
* Remove references to google.cloud.operation from spanner * Remove unused import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spanner's docstrings were actually incorrect, as spanner is using gax futures but was documented as using google.cloud.operation. gax futures will be replaced by google.cloud.future.operation and in the meantime the interface is the same. This change removes references to google.cloud.operation.
This is not a breaking change for spanner.
Towards #3617