FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix url encoding of list parameters by leameow · Pull Request #3657 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Fix url encoding of list parameters - #3657

Merged
tseaver merged 1 commit into
googleapis:masterfrom
leameow:master
Jul 25, 2017
ConversationCommits (1)ChecksFiles changed
Merged

Fix url encoding of list parameters#3657
tseaver merged 1 commit into
googleapis:masterfrom
leameow:master

Conversation

leameow commented Jul 24, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Issue can easily be reproduce with API using list parameters such as testIamPermissions in Cloud Storage.
Before the fix, using a list end up with this error:

bucket.test_iam_permissions(['storage.buckets.delete','storage.buckets.get'])
# Raises
# google.cloud.exceptions.BadRequest: 400 null is not a valid Google Cloud Storage permission. (GET https://www.googleapis.com/storage/v1/b/some-buckets/iam/testPermissions?permissions=%5B%27storage.buckets.delete%27%2C+%27storage.buckets.get%27%5D)

googlebot commented Jul 24, 2017

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 24, 2017

leameow commented Jul 24, 2017

Copy link
Copy Markdown
Contributor Author

I signed it!

googlebot commented Jul 24, 2017

Copy link
Copy Markdown

CLAs look good, thanks!

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 24, 2017
tseaver suggested changes Jul 24, 2017
View reviewed changes

tseaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@Isra17 Thanks for the patch! Can you please add a unit test (like the one in your example above) which fails when 'query_params' contains a list value?

leameow commented Jul 25, 2017

Copy link
Copy Markdown
Contributor Author

Couldn't really add a test from my initial example since API tests rely on mocking, but I modified the _http test.

tseaver merged commit a88a334 into googleapis:master Jul 25, 2017

tseaver commented Jul 25, 2017

Copy link
Copy Markdown
Contributor

@Isra17 Thank you very much!

dhermes mentioned this pull request Aug 4, 2017
Merged
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
Correctly url-encode list parameters (googleapis#3657)
43bae9a
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Correctly url-encode list parameters (googleapis#3657)
cfbe917
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Correctly url-encode list parameters (googleapis#3657)
0470a4e
parthea pushed a commit that referenced this pull request Nov 24, 2025
Correctly url-encode list parameters (#3657)
1232f7f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
tseaver tseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: core cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL