Moving bytes signing helpers from core to storage. - #3668
Merged
theacodes merged 1 commit intoJul 25, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
theacodes
approved these changes
Jul 25, 2017
Copy link
Copy Markdown
Contributor
|
Wouldn't it make more sense to base this on #3667? For instance, at that point, you could entirely remove the credentials module from core. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@tseaver I'm trying to reduce burden on reviewers by making the PR small. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Yeah, but then we have to review a third PR which just removes that module? The only thing gonna be left in it after these two are merged is the copyright comment. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@tseaver I plan on rebasing the one that gets merged 2nd. |
Sorry, something went wrong.
This was referenced Jul 25, 2017
This was referenced Aug 4, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAssignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of @jonparrott's effort to slim down / stabilize core.
Temporarily labeled "do not merge" so we can discuss "churn" first.