Add 'Client.get_job' API wrapper. - #3804
Merged
tseaver merged 6 commits intoSep 11, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
tswast
requested changes
Aug 14, 2017
tswast
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Woohoo! Just one small integer conversion request.
Sorry, something went wrong.
Comment thread
bigquery/google/cloud/bigquery/client.py
|
|
||
| path = '/projects/{}/jobs/{}'.format(project, job_name) | ||
|
|
||
| resource = self._connection.api_request( |
This comment was marked as spam.
Comment thread
bigquery/google/cloud/bigquery/job.py
Outdated
| self.priority = configuration.get('priority') | ||
| self.write_disposition = configuration.get('writeDisposition') | ||
| self.maximum_billing_tier = configuration.get('maximumBillingTier') | ||
| self.maximum_bytes_billed = configuration.get('maximumBytesBilled') |
This comment was marked as spam.
tswast
reviewed
Aug 16, 2017
Comment thread
bigquery/google/cloud/bigquery/client.py
Outdated
| return QueryJob.from_api_repr(resource, self) | ||
| raise ValueError('Cannot parse job resource') | ||
|
|
||
| def get_job(self, job_name, project=None): |
This comment was marked as spam.
tswast
reviewed
Aug 24, 2017
Comment thread
bigquery/google/cloud/bigquery/job.py
| configuration.get('maxBadRecords')) | ||
| self.null_marker = configuration.get('nullMarker') | ||
| self.quote_character = configuration.get('quote') | ||
| self.skip_leading_rows = _int_or_none( |
This comment was marked as spam.
This comment was marked as spam.
tswast
reviewed
Aug 24, 2017
Comment thread
bigquery/tests/unit/test__helpers.py
| self.assertEqual(param.to_api_repr(), EXPECTED) | ||
|
|
||
|
|
||
| class Test__query_param_from_api_repr(unittest.TestCase): |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
"maximumBytesBilled": {
"type": "string",
"description": "[Optional] Limits the bytes billed for this job. Queries that will have bytes billed beyond this limit will fail (without incurring a charge). If unspecified, this will be set to your project default.",
"format": "int64"
},
From https://www.googleapis.com/discovery/v1/apis/bigquery/v2/rest
Since it needs to represent a 64-bit integer the JSON number type is insufficient, so it must be sent as a string.
tswast
approved these changes
Sep 11, 2017
Comment thread
bigquery/tests/unit/test__helpers.py
| self.assertEqual(param.to_api_repr(), EXPECTED) | ||
|
|
||
|
|
||
| class Test__query_param_from_api_repr(unittest.TestCase): |
This comment was marked as spam.
tseaver
added a commit
that referenced
this pull request
Sep 11, 2017
* Allow assigning 'None' to '_TypedProperty' properties. * Ensure that configuration properties are copied when (re)loading jobs.
tswast
pushed a commit
that referenced
this pull request
Sep 25, 2017
* Allow assigning 'None' to '_TypedProperty' properties. * Ensure that configuration properties are copied when (re)loading jobs.
tswast
pushed a commit
that referenced
this pull request
Oct 12, 2017
* Allow assigning 'None' to '_TypedProperty' properties. * Ensure that configuration properties are copied when (re)loading jobs.
tswast
pushed a commit
that referenced
this pull request
Oct 16, 2017
* Allow assigning 'None' to '_TypedProperty' properties. * Ensure that configuration properties are copied when (re)loading jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that 177caa5 fixes a longstanding bug: Job configuration properties were not replaced when loading a job from the server. Unfortunately, I can't find the bug after the huge pile of issue closures this week.
The helper for constructing concrete query params added in cc4ba04 is a more general form of the one I did in-place in #3802, and should replace that version.