Add 'on_error' argument to 'retry.retry_target' and 'Retry'. - #3891
Merged
tseaver merged 3 commits intoAug 29, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Permit application code to reset / fix-up state before retrying. See: #3889
dhermes
approved these changes
Aug 28, 2017
dhermes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM though I think you should let @jonparrott have a look before merging
Sorry, something went wrong.
Comment thread
core/google/api/core/retry.py
Outdated
| sleep_generator (Iterator[float]): An infinite iterator that determines | ||
| how long to sleep between retries. | ||
| deadline (float): How long to keep retrying the target. | ||
| on_error(Callable): A function to call while processing a retryable |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
core/google/api/core/retry.py
Outdated
|
|
||
| Args: | ||
| func (Callable): The callable to add retry behavior to. | ||
| on_error(Callable): A function to call while processing a |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
core/tests/unit/api_core/test_retry.py
| raise ValueError() | ||
| return 42 | ||
|
|
||
| result = retry.retry_target( |
This comment was marked as spam.
Comment thread
core/tests/unit/api_core/test_retry.py
|
|
||
| result = retry.retry_target( | ||
| target, predicate, range(10), None, on_error=on_error) | ||
|
|
This comment was marked as spam.
This comment was marked as spam.
theacodes
reviewed
Aug 28, 2017
theacodes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
looks mostly good, just a few questions.
Sorry, something went wrong.
Comment thread
core/google/api/core/retry.py
Outdated
| raise | ||
| last_exc = exc | ||
| if on_error is not None: | ||
| on_error() |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
core/google/api/core/retry.py
Outdated
| sleep_generator (Iterator[float]): An infinite iterator that determines | ||
| how long to sleep between retries. | ||
| deadline (float): How long to keep retrying the target. | ||
| on_error(Callable): A function to call while processing a retryable |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
core/google/api/core/retry.py
| self._deadline = deadline | ||
|
|
||
| def __call__(self, func): | ||
| def __call__(self, func, on_error=None): |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Permit application code to reset / fix-up state before retrying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Permit application code to reset / fix-up state before retrying.
See: #3889