FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use queue if provided in kwargs by garykrige · Pull Request #3924 · googleapis/google-cloud-python · GitHub

Use queue if provided in kwargs - #3924

Merged
lukesneeringer merged 1 commit into
googleapis:masterfrom
garykrige:patch-1
Sep 6, 2017
Merged

Use queue if provided in kwargs#3924
lukesneeringer merged 1 commit into
googleapis:masterfrom
garykrige:patch-1

Conversation

Copy link
Copy Markdown
Contributor

Bugfix

Fix for a new Queue being instantiated regardless of whether a queue is passed in or not.

Fix for a new Queue being instantiated regardless of whether a queue is passed in or not.

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 6, 2017

Copy link
Copy Markdown
Contributor Author

I signed it!

Copy link
Copy Markdown

CLAs look good, thanks!

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 6, 2017

BradWhittington left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Makes sense.

Copy link
Copy Markdown
Contributor

Good catch @garykrige! Thanks!

lukesneeringer merged commit 6b0b256 into googleapis:master Sep 6, 2017

tseaver commented Sep 6, 2017

Copy link
Copy Markdown
Contributor

We really should add a test assertion that the passed-in queue is used.

parthea pushed a commit that referenced this pull request Mar 2, 2026
Fix for a new Queue being instantiated regardless of whether a queue is passed in or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL