FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

BQ: rename XJob.name to XJob.job_id. by tswast · Pull Request #3962 · googleapis/google-cloud-python · GitHub

BQ: rename XJob.name to XJob.job_id. - #3962

Merged
tswast merged 2 commits into
googleapis:bigquery-b2from
tswast:bq-job-id
Sep 15, 2017
Merged

BQ: rename XJob.name to XJob.job_id.#3962
tswast merged 2 commits into
googleapis:bigquery-b2from
tswast:bq-job-id

Conversation

tswast commented Sep 14, 2017

Copy link
Copy Markdown
Contributor

To go with all our other renames.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 14, 2017

tswast commented Sep 14, 2017

Copy link
Copy Markdown
Contributor Author

Copy link
Copy Markdown
Contributor

Let me know if you need/want an assist on that system test failure.

tswast commented Sep 15, 2017

Copy link
Copy Markdown
Contributor Author

I think some of the failures are a few system tests got missed in #3959. I pushed a fix.

tswast commented Sep 15, 2017

Copy link
Copy Markdown
Contributor Author

System tests will be available at https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/3296

tswast commented Sep 15, 2017

Copy link
Copy Markdown
Contributor Author

I still can't get the logs to load for the system tests, but they pass locally. Merging.

tswast merged commit 69d169e into googleapis:bigquery-b2 Sep 15, 2017
tswast deleted the bq-job-id branch September 15, 2017 18:19
tswast added a commit that referenced this pull request Sep 25, 2017
* BQ: rename XJob.name to XJob.job_id.

* BQ: Remove references to table.name
tswast added a commit that referenced this pull request Oct 12, 2017
* BQ: rename XJob.name to XJob.job_id.

* BQ: Remove references to table.name
tswast added a commit that referenced this pull request Oct 16, 2017
* BQ: rename XJob.name to XJob.job_id.

* BQ: Remove references to table.name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL