Video Intelligence import issue - #3985
Merged
lukesneeringer merged 3 commits intoSep 15, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I know why! Because we do not run video intelligence tests in CI. Good times. Fixing that first thing Monday morning. Fixed. |
Sorry, something went wrong.
dhermes
approved these changes
Sep 15, 2017
dhermes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM. D'oh!
Any way we can make this autogen stuff less cowboy?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I am wondering the same thing. We need a better process. This is a problem for every language, also. The actual issue behind this one was maddening -- it turns out that protoc on Mac OS X and protoc on the (Ubuntu) Docker image do not actually output the same thing (!!!), and one of the outputs does not work (!!!). |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAssignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated change that fixes an issue with importing Video Intelligence previously. (I have no idea how the unit tests passed before.)