| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
From #4027, which this PR supersedes: Draft release notes: google-cloud-spanner 0.27.1
Internal housekeeping not included in release notes:
|
Sorry, something went wrong.
|
@lukesneeringer @jonparrott We also want a quick review of the API Reference docs to make sure it's reasonably in sync with the client library. This is just for the manual docs; the autogen docs should be fine. |
Sorry, something went wrong.
|
@lukesneeringer is this ready for me to review the docs? |
Sorry, something went wrong.
|
Thanks @lukesneeringer, @tseaver, and @jonparrott. |
Sorry, something went wrong.
|
Non-documentation issues/concerns
Documentation issues (these may be deferred by moving them into their own bugs):
|
Sorry, something went wrong.
|
Thanks for your detailed review @jonparrott! @lukesneeringer is the "Non-documentation issues/concern" a breaking change to fix later. I'm assuming consistency is important here; what do you think? @tseaver It seems like documentation items 2-6 (shown as 1-5 due to the graphic) should be fixed before the Beta release. The other presentation and organizational concerns can be fixed before GA. Do you agree @jonparrott and @lukesneeringer? FYI @vkedia |
Sorry, something went wrong.
|
Item 6 should really be fixed ASAP. |
Sorry, something went wrong.
|
@jonparrott I see what you're saying with that. The Python API Reference combines manual and GAPIC at the same level, whereas the Ruby docs (and those for other languages) puts it another level below under v1. @lukesneeringer Is this particularly difficult to fix with the current docs setup? I don't think we want to create a lot of work to finalize docs for Beta, but I do see the usability concern that Jon is raising. |
Sorry, something went wrong.
|
Putting in PRs for these. |
Sorry, something went wrong.
|
Okay, I fixed all of these except the spanner alias (the item without a PR number in the comment above is waiting on #4054 to be approved, because it needs it as a baseline). @jonparrott, I am having trouble deciding what to do about the spanner_v1 thing. I actually considered moving it, and decided against it because doing so would break people in a few cases (e.g. anyone who typed from google.cloud.spanner.client import Client, which the documentation previously recommended in one spot, now corrected). With Pub/Sub, we were breaking everyone anyway, so it was an obvious decision. Additionally, since Pub/Sub was a thin client, it was quite necessary to do this. I am willing to do it here also, but due to the potential customer randomization, as well as the thicker client, it is less clear to me that it is the correct path. Please advise. :-) |
Sorry, something went wrong.
|
I think we need to make a firm decision on the api -> api_{version} going forwards - either it's a direct alias or it adds functionality. Either spanner or pubsub will need to change. I strongly think we should follow what pubsub did - spanner is transitioning into beta so breaking is allowed (although less than ideal, sure). |
Sorry, something went wrong.
|
fwiw, the pubsub samples use google.cloud.pubsub_v1 explicitly. |
Sorry, something went wrong.
|
Okay, I am happy to change it then. :-) |
Sorry, something went wrong.
|
Thanks, @lukesneeringer for fixing just about everything. I agree that I'm happier with all the API suffixes in a post-4054 world, too. What's the PR for the alias fix? |
Sorry, something went wrong.
There is not one yet. I had wall-to-wall meetings followed by lunch. :-) |
Sorry, something went wrong.
|
Understood. Must be Monday. Lots of meetings. |
Sorry, something went wrong.
|
@jonparrott @bjwatson Okay, #4064 exists. This is probably a breaking change at the margins. In other words, most users will not be affected, but some might be. In particular, we did have at least one doc that told users to from google.cloud.spanner.client import Client, and that will break. Do we need any kind of migration guide? |
Sorry, something went wrong.
|
@lukesneeringer We should at least have release notes that explain this breaking change. |
Sorry, something went wrong.
|
@bjwatson We will have release notes either way. :-) |
Sorry, something went wrong.
|
Woo hoo! Great job @lukesneeringer, @tseaver, and @jonparrott! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This shall be the "root" PR for getting Spanner to beta. Multiple PRs are going to be made using it as a base.
The remaining to-do items are: