Test blob ACL methods w/ 'user_project' set. - #4088
Merged
tseaver merged 1 commit intoSep 29, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Note that this test does not exercise the IAM features, because I now suspect them to be invalid (see #4087). |
Sorry, something went wrong.
dhermes
approved these changes
Sep 29, 2017
dhermes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Mostly LGTM
Sorry, something went wrong.
Comment thread
storage/tests/system.py
Outdated
| acl.reload() | ||
| acl.all().grant_read() | ||
| acl.save() | ||
| self.assertTrue('READER' in acl.all().get_roles()) |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
storage/tests/system.py
Outdated
| new_bucket_name, requester_pays=True) | ||
| self.case_buckets_to_delete.append(new_bucket_name) | ||
|
|
||
| with_up = Config.CLIENT.bucket( |
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
Author
|
Rebased after merging #4086. I will merge when CI is green. |
Sorry, something went wrong.
tseaver
added a commit
that referenced
this pull request
Oct 2, 2017
tseaver
added a commit
that referenced
this pull request
Oct 5, 2017
tseaver
added a commit
that referenced
this pull request
Oct 10, 2017
tseaver
added a commit
that referenced
this pull request
Oct 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses #4086 as a base.