BQ: remove fetch_data and client references from QueryResults - #4144
Merged
tswast merged 1 commit intoOct 10, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
tswast
force-pushed
the
bq-query-results
branch
from
b6e67fd to
d10ff7e
Compare
October 9, 2017 21:05
jba
reviewed
Oct 9, 2017
Comment thread
bigquery/google/cloud/bigquery/client.py
Outdated
| if selected_fields is not None: | ||
| params['selectedFields'] = [f.name for f in selected_fields] | ||
| params['selectedFields'] = ','.join( | ||
| [f.name for f in selected_fields]) |
This comment was marked as spam.
This comment was marked as spam.
jba
approved these changes
Oct 9, 2017
tswast
force-pushed
the
bq-query-results
branch
from
d10ff7e to
91e0e43
Compare
October 10, 2017 17:22
Now QueryResults is just a container for the getQueryResults response.
tswast
force-pushed
the
bq-query-results
branch
from
91e0e43 to
740c89a
Compare
October 10, 2017 17:42
Copy link
Copy Markdown
Contributor
Author
|
Coverage failure is for list_partitions. I'll double-check the diff to make sure I didn't delete a test. |
Sorry, something went wrong.
tswast
added a commit
that referenced
this pull request
Oct 12, 2017
Now QueryResults is just a container for the getQueryResults response.
tswast
added a commit
that referenced
this pull request
Oct 16, 2017
Now QueryResults is just a container for the getQueryResults response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #4143.
Now QueryResults is just a container for the getQueryResults response.