FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add scope for trace client by liyanhui1228 · Pull Request #4158 · googleapis/google-cloud-python · GitHub

Add scope for trace client - #4158

Merged
liyanhui1228 merged 1 commit into
googleapis:masterfrom
liyanhui1228:scope
Oct 11, 2017
Merged

Add scope for trace client#4158
liyanhui1228 merged 1 commit into
googleapis:masterfrom
liyanhui1228:scope

Conversation

Copy link
Copy Markdown
Contributor

Adding the scope needed when setting credentials file via $GOOGLE_APPLICATION_CREDENTIALS.

liyanhui1228 added the api: cloudtrace Issues related to the Cloud Trace API. label Oct 11, 2017
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 11, 2017

dhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

liyanhui1228 merged commit 318b04f into googleapis:master Oct 11, 2017
liyanhui1228 deleted the scope branch October 11, 2017 22:29

Copy link
Copy Markdown
Contributor Author

@dhermes Could you please do a release for the trace package? Thanks!

dhermes commented Oct 12, 2017

Copy link
Copy Markdown
Contributor

@liyanhui1228 Can you draft some release notes, in the style of https://github.com/GoogleCloudPlatform/google-cloud-python/releases/tag/storage-1.3.0?

You can run

$ git log -1 --pretty=%H 
c0bbf6d24bf43d8ca68f0af9c615734cd7607b89
$ git log trace-0.15.4..HEAD -- trace/

to decide what should go in the release notes


I'm not sure a release will be easy, google-cloud-core may confuse things. Let's hope not.

Copy link
Copy Markdown
Contributor Author

@dhermes The release notes can just be empty like what we did in last release :)
What problem will be caused by google-cloud-core?

Copy link
Copy Markdown
Contributor

We should always publish release notes when we make releases, even if the changes are trivial.

liyanhui1228 commented Oct 12, 2017
edited
Loading

Copy link
Copy Markdown
Contributor Author

@jonparrott Thanks! I drafted the release note like below,

Notable Implementation Changes

Packaging

dhermes commented Oct 12, 2017

Copy link
Copy Markdown
Contributor

@liyanhui1228 I'd be fine leaving the deps changes out of the release notes. What about #3922? (It looks like @lukesneeringer intended there to be a 0.15.5 release but never managed one.)

Copy link
Copy Markdown
Contributor Author

@dhermes OK! I removed the dependencies notes, and added packaging note.

Copy link
Copy Markdown
Contributor Author

Friendly ping.

dhermes commented Oct 13, 2017

Copy link
Copy Markdown
Contributor

I made https://github.com/GoogleCloudPlatform/google-cloud-python/tree/trace-cherry-pick to avoid being gated on google-cloud-core. In particular:

commit 863d293f16f7df1962a4a367b8bf913daefe02fe
Author: Danny Hermes <daniel.j.hermes@gmail.com>
Date:   Fri Oct 13 15:33:01 2017 -0700

    Rolling back the dependency update for trace.
    
    This is so that an "off-master" release can be done
    without being gated on a `google-cloud-core` release.

diff --git a/trace/setup.py b/trace/setup.py
index c14fbbe..8072778 100644
--- a/trace/setup.py
+++ b/trace/setup.py
@@ -9,7 +9,8 @@ from setuptools import setup, find_packages
 
 install_requires = [
     'google-gax>=0.15.7, <0.16dev',
-    'google-cloud-core[grpc] >= 0.27.1, < 0.28dev',
+    'googleapis-common-protos[grpc]>=1.5.2, <2.0dev',
+    'google-cloud-core >= 0.27.0, < 0.28dev',
 ]
 
 setup(

Copy link
Copy Markdown
Contributor Author

Thanks! So this release will be based on the trace-cherry-pick branch? Can we release it today?

dhermes commented Oct 13, 2017

Copy link
Copy Markdown
Contributor

The branch is now deleted and immortalized as https://github.com/GoogleCloudPlatform/google-cloud-python/releases/tag/trace-0.15.5.

This build (https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/3757) should push to PyPI.

parthea pushed a commit that referenced this pull request Oct 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudtrace Issues related to the Cloud Trace API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL