| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
@dhermes As an aside, how would you feel if I dropped the google.api.core.helpers package and just moved all the modules up one, e.g., google.api.core.general_helpers, google.api.core.grpc_helpers, etc.? |
Sorry, something went wrong.
-0, but they arguably do not need to all end in _helpers. What about google.api.code.helpers.general? And the usage pattern could be... from google.api.core import helpers
@helpers.general.wraps(thing)
def other_thingMy concern is that there will be a lot of helpers things interspersed with other stuff. And while helpers.general looks kind of dumb, helpers.grpc makes total sense. The general helpers could also just go into __init__.py. helpers.wraps is fine. |
Sorry, something went wrong.
|
@jonparrott I am big time 👍 on reducing the number of nested packages. |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM, though I'd like to see a code snippet with the failure you intend to workaround here.
Sorry, something went wrong.
| assert replacement() == 42 | ||
|
|
||
|
|
||
| def test_wraps_partial(): |
I'll send a separate PR to do that. |
Sorry, something went wrong.
|
Can someone merge this into the bigquery-b2 branch? I'm not sure how to do that. |
Sorry, something went wrong.
|
@jba I can do it. Will a rebase be OK? |
Sorry, something went wrong.
|
@tswast What's the right way to get this into bigquery-b2? Maybe just cherry-pick? |
Sorry, something went wrong.
|
Probably best to rebase bigquery-b2 on master rather than cherry-pick. We'll have to rebase for the final push anyway. |
Sorry, something went wrong.
|
@tswast I agree. Do you need me to do that or you guys have it covered? |
Sorry, something went wrong.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
No description provided.