Language: Add classify_text method (v1). - #4283
Merged
lukesneeringer merged 5 commits intoNov 2, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
dhermes
approved these changes
Oct 30, 2017
dhermes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Cursory LGTM
Sorry, something went wrong.
lukesneeringer
force-pushed
the
language-v1-updates
branch
from
265ef6f to
a9474ee
Compare
November 1, 2017 18:51
Copy link
Copy Markdown
Contributor
Author
|
Okay, I tested this and am happy with it (but need to see what is up with CI). @dhermes, I want to do the following:
How does this interact with the releases you just did? I want to make sure I do not step on your toes. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@lukesneeringer I think it'd be fine to do two releases only (since you don't depend on a new version of core):
|
Sorry, something went wrong.
dhermes
force-pushed
the
language-v1-updates
branch
from
0155102 to
fa1d8cd
Compare
November 1, 2017 23:35
parthea
pushed a commit
that referenced
this pull request
Jul 6, 2023
* Language: Add `classify_text` method (v1). * Update v1beta2 also.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAssignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the classify_text method currently in the v1beta2 API version to the v1 version. This should be held until November 15 (the endpoint will not be live on v1 until then).