Pub/Sub autogen refresh - #4297
Closed
lukesneeringer wants to merge 6 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
This now seems to be in good shape. Lobbing to @jonparrott for review. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@lukesneeringer FYI #4296 is an uber-release, but I was planning on checking on you before actually pushing the tag for Pub/Sub. |
Sorry, something went wrong.
theacodes
approved these changes
Oct 31, 2017
theacodes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Mostly LGTM
Sorry, something went wrong.
Comment thread
pubsub/google/cloud/pubsub_v1/gapic/publisher_client.py
| from google.protobuf import field_mask_pb2 | ||
|
|
||
| _GAPIC_LIBRARY_VERSION = pkg_resources.get_distribution( | ||
| 'google-cloud-pubsub', ).version |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
pubsub/google/cloud/pubsub_v1/gapic/publisher_client.py
| credentials=credentials, | ||
| scopes=self._DEFAULT_SCOPES) | ||
|
|
||
| self.iam_policy_stub = (iam_policy_pb2.IAMPolicyStub(channel)) |
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
|
Closing in favor or #4438 (which literally pushed this exact set of history to start). But that PR is in the GoogleCloudPlatform remote so we can run system tests. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAssignees
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a merger of Pub/Sub with google.api_core. Marked do not merge while Ernest and I work out some khinks.