BigQuery: Use DatasetListItem for client.list_datasets - #4439
Merged
tswast merged 4 commits intoDec 6, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
tswast
force-pushed
the
bq-datasetref
branch
from
dad8587 to
cb10a2b
Compare
November 27, 2017 19:12
Copy link
Copy Markdown
Contributor
Author
|
Ping. Please review. |
Sorry, something went wrong.
Listing datasets only includes a subset of the properties available on a dataset. The DatasetListItem class is used to explicitly document which features are available and to prevent confusion from trying to use the resulting object in other contexts, like updating.
tseaver
suggested changes
Dec 5, 2017
Comment thread
bigquery/google/cloud/bigquery/dataset.py
Outdated
| :rtype: str | ||
| :returns: the project. | ||
| """ | ||
| return self._properties.get('datasetReference').get('projectId') |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
bigquery/google/cloud/bigquery/dataset.py
Outdated
| :rtype: str | ||
| :returns: the dataset ID. | ||
| """ | ||
| return self._properties.get('datasetReference').get('datasetId') |
This comment was marked as spam.
Comment thread
bigquery/google/cloud/bigquery/dataset.py
Outdated
| :rtype: dict, {str -> str} | ||
| :returns: A dict of the the dataset's labels. | ||
| """ | ||
| return self._properties['labels'] |
This comment was marked as spam.
This comment was marked as spam.
tseaver
approved these changes
Dec 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Listing datasets only includes a subset of the properties available on a
dataset. The DatasetListItem class is used to explicitly document which
features are available and to prevent confusion from trying to use the
resulting object in other contexts, like updating.
Closes #4373.