Remove Timestamp from Spanner - #4980
Merged
chemelnucfin merged 2 commits intoMar 12, 2018
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This was referenced Mar 1, 2018
chemelnucfin
force-pushed
the
timestamp_to_api_core_2
branch
6 times, most recently
from
18a79d4 to
543112a
Compare
March 10, 2018 00:21
chemelnucfin
force-pushed
the
timestamp_to_api_core_2
branch
from
543112a to
a5eee9c
Compare
March 10, 2018 00:26
Copy link
Copy Markdown
Contributor
|
@tseaver can you review this? (I don't have the bandwidth) |
Sorry, something went wrong.
tseaver
suggested changes
Mar 12, 2018
Comment thread
spanner/google/cloud/spanner_v1/_helpers.py
Outdated
| nanosecond=nanos, tzinfo=UTC) | ||
| from google.cloud.spanner_v1.proto import type_pb2 | ||
| from google.protobuf.struct_pb2 import ListValue | ||
| from google.protobuf.struct_pb2 import Value |
This comment was marked as spam.
tseaver
approved these changes
Mar 12, 2018
Copy link
Copy Markdown
Contributor
|
Please note that now we need to cut a release of api_core before we can release any new versions of spanner. |
Sorry, something went wrong.
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diffbase #4979