FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixup datastore demo to match API changes by tseaver · Pull Request #504 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Fixup datastore demo to match API changes - #504

Merged
tseaver merged 3 commits into
googleapis:masterfrom
tseaver:fixup-demo-20150107
Jan 7, 2015
ConversationCommits (3)ChecksFiles changed
Merged

Fixup datastore demo to match API changes#504
tseaver merged 3 commits into
googleapis:masterfrom
tseaver:fixup-demo-20150107

Conversation

tseaver commented Jan 7, 2015

Copy link
Copy Markdown
Contributor

No description provided.

dhermes commented Jan 7, 2015

Copy link
Copy Markdown
Contributor

More of favorite:

./gcloud/datastore/demo/demo.py:45:23: E261 at least two spaces before inline comment
./gcloud/datastore/demo/demo.py:51:5: E129 visually indented line with same indent as next logical line

Is there an issue running tox -e lint locally?

dhermes reviewed Jan 7, 2015
View reviewed changes
Comment thread gcloud/datastore/demo/demo.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes reviewed Jan 7, 2015
View reviewed changes
Comment thread gcloud/datastore/demo/demo.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver commented Jan 7, 2015

Copy link
Copy Markdown
Contributor Author

I didn't run lint because I was touching only demo code, and lint has been extra slow. ec034e1 should fix it.

dhermes commented Jan 7, 2015

Copy link
Copy Markdown
Contributor

If you set

export GCLOUD_REMOTE_FOR_LINT="upstream"
export GCLOUD_BRANCH_FOR_LINT="master"

as suggested in CONTRIBUTING it is much faster.

coveralls commented Jan 7, 2015

Copy link
Copy Markdown

Changes Unknown when pulling ec034e1 on tseaver:fixup-demo-20150107 into * on GoogleCloudPlatform:master*.

tseaver commented Jan 7, 2015

Copy link
Copy Markdown
Contributor Author

Re: speeding up lint via env vars -- I've seen false positives there, so left them always upset. It has slowed down: in fact, I think I've seen evidence that it is running twice (reporting duplicate errors for the same line numbers, but in groups).

dhermes commented Jan 7, 2015

Copy link
Copy Markdown
Contributor

LGTM

The false positives are few and far between, but it's up to you to weight the speed-up against the occasional false positive.

RE: "Duplicates". That's not new. It comes from pylint itself recursively going into dependencies and some modules are a dependency for more than one module. If we weren't using different configs for different filesets, and just running pylint without specifying filenames, I think it would go away.

tseaver added a commit that referenced this pull request Jan 7, 2015
Merge pull request #504 from tseaver/fixup-demo-20150107
8caac14 
Fixup datastore demo to match API changes
tseaver merged commit 8caac14 into googleapis:master Jan 7, 2015
tseaver deleted the fixup-demo-20150107 branch January 7, 2015 22:52
dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015
atulep pushed a commit that referenced this pull request Apr 6, 2023
chore: delete handwritten samples (#504)
ac0b4e9 
* chore: delete handwritten samples

* merge fix?

* moar fix

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update samples/snippets/README.rst

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
chore: delete handwritten samples (#504)
3f2cd61 
* chore: delete handwritten samples

* merge fix?

* moar fix

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update samples/snippets/README.rst

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 18, 2023
chore: delete handwritten samples (#504)
9cef2b6 
* chore: delete handwritten samples

* merge fix?

* moar fix

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update samples/snippets/README.rst

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Aug 15, 2023
chore(python): upgrade gcp-releasetool in .kokoro [autoapprove] (#504)
76cf3fd 
Source-Link: https://togithub.com/googleapis/synthtool/commit/5f2a6089f73abf06238fe4310f6a14d6f6d1eed3
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97
parthea pushed a commit that referenced this pull request Sep 22, 2023
build(deps): bump certifi from 2022.9.24 to 2022.12.7 in /synthtool/g…
c1e1098 
…cp/templates/python_library/.kokoro (#504)

Source-Link: googleapis/synthtool@b4fe62e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3bf87e47c2173d7eed42714589dc4da2c07c3268610f1e47f8e1a30decbfc7f1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
chore: store artifacts in placer [autoapprove] (#504)
69a1e52 
Source-Link: https://togithub.com/googleapis/synthtool/commit/cb960373d12d20f8dc38beee2bf884d49627165e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2d816f26f728ac8b24248741e7d4c461c09764ef9f7be3684d557c9632e46dbd
parthea pushed a commit that referenced this pull request Oct 21, 2023
chore(deps): update all dependencies (#504)
5695965
parthea pushed a commit that referenced this pull request Oct 21, 2023
fix: add missing argument description (#504)
a76e419 
add argument description for restore() method
parthea pushed a commit that referenced this pull request Oct 21, 2023
build(deps): [autoapprove] bump certifi from 2022.12.7 to 2023.7.22 (#…
5971964 
…504)

Source-Link: googleapis/synthtool@395d53a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6c1cbc75c74b8bdd71dada2fa1677e9d6d78a889e9a70ee75b93d1d0543f96e1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Oct 21, 2023
chore(python): update release script dependencies (#504)
1c6ba13 
Source-Link: googleapis/synthtool@25083af
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
build: [autoapprove] bump cryptography from 41.0.2 to 41.0.3 (#504)
9314817 
Source-Link: googleapis/synthtool@352b9d4
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3e3800bb100af5d7f9e810d48212b37812c1856d20ffeafb99ebe66461b61fc7

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
chore: delete handwritten samples (#504)
a13da4d 
* chore: delete handwritten samples

* merge fix?

* moar fix

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update samples/snippets/README.rst

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Aug 21, 2025
chore(deps): update all dependencies (#504)
2c538e4
parthea pushed a commit that referenced this pull request Sep 16, 2025
chore(deps): update all dependencies (#504)
ae2a2a4
parthea pushed a commit that referenced this pull request Sep 18, 2025
doc: show conventional commits instructions (#504)
97429b7 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery-pandas/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Towards #367  🦕
parthea added a commit that referenced this pull request Nov 22, 2025
feat: add WarmAndPing request for channel priming (#504)
530cca9 
* chore: use gapic-generator-python 0.63.2

PiperOrigin-RevId: 427792504

Source-Link: googleapis/googleapis@55b9e1e

Source-Link: googleapis/googleapis-gen@bf4e86b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmY0ZTg2Yjc1M2Y0MmNiMGVkYjFmZDUxZmJlODQwZDdkYTBhMWNkZSJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat: add WarmAndPing request for channel priming

PiperOrigin-RevId: 428795660

Source-Link: googleapis/googleapis@6cce671

Source-Link: googleapis/googleapis-gen@2282bc1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjI4MmJjMWIwODEzNjRlYTc4MzMwMGJlOTFhOGMxNGNiNGE3MThjNCJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix replacement in owlbot.py

* remove autogenerated snippets

* chore: use gapic-generator-python 0.63.4

chore: fix snippet region tag format
chore: fix docstring code block formatting
PiperOrigin-RevId: 430730865

Source-Link: googleapis/googleapis@ea58002

Source-Link: googleapis/googleapis-gen@ca893ff
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2E4OTNmZjhhZjI1ZmM3ZmUwMDFkZTE0MDVhNTE3ZDgwNDQ2ZWNjYSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: update copyright year to 2022

PiperOrigin-RevId: 431037888

Source-Link: googleapis/googleapis@b3397f5

Source-Link: googleapis/googleapis-gen@510b54e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTEwYjU0ZTFjZGVmZDUzMTczOTg0ZGYxNjY0NTA4MTMwOGZlODk3ZSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: disable Python snippetgen for bigtable

PiperOrigin-RevId: 431126635

Source-Link: googleapis/googleapis@dbfbfdb

Source-Link: googleapis/googleapis-gen@4b4a4e7
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGI0YTRlN2ZlYzczYzYwOTEzZDhiMTA2MWYwYjI5YWZmYjFlMmE3MiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Nov 24, 2025
chore(python): update dependencies in .kokoro/docker/docs (#504)
b2bce3b 
* chore(python): update dependencies in .kokoro/docker/docs

Source-Link: googleapis/synthtool@59171c8
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2ed982f884312e4883e01b5ab8af8b6935f0216a5a2d82928d273081fc3be562

* See https://github.com/googleapis/synthtool/pull/2033/files

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
feat: use contextvars.ConvextVar instead of threading.local in Python 3
96975cd 
Closes #504 

Co-authored-by: ndavydovdev <ndavydov@aita.travel>
parthea pushed a commit that referenced this pull request Nov 26, 2025
fix: support string type response.data (#504)
f859981
parthea pushed a commit that referenced this pull request Nov 26, 2025
chore: release 1.14.2 (#505)
4babb89 
🤖 I have created a release \*beep\* \*boop\* 
---
### [1.14.2](https://www.github.com/googleapis/google-auth-library-python/compare/v1.14.1...v1.14.2) (2020-05-07)


### Bug Fixes

* support string type response.data ([#504](https://www.github.com/googleapis/google-auth-library-python/issues/504)) ([9b7228e](https://www.github.com/googleapis/google-auth-library-python/commit/9b7228ec849e311bcb4007ad3e23cf2f1e54a721))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
parthea pushed a commit that referenced this pull request Mar 6, 2026
refactor: erase strip_backticks() helper (#504)
5e00036
parthea pushed a commit that referenced this pull request Mar 9, 2026
chore(deps): update dependency opentelemetry-api to v1.28.2 (#504)
ecba797
parthea pushed a commit that referenced this pull request Mar 9, 2026
docs: remove and replace deprecated function download_as_string() (#508)
7fa5bff 
Remove deprecated function download_as_string(), replace with download_as_bytes(). [1]
[1] https://github.com/googleapis/python-storage/blob/master/google/cloud/storage/blob.py#L138

Fixes #504 🦕
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: datastore Issues related to the Datastore API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL