Add a 'Batch': collects non-transactional saves / deletes. by tseaver · Pull Request #509 · googleapis/google-cloud-python · GitHub

Closes #421.

Changes Unknown when pulling 90a20d1 on tseaver:421-dataset_batch_put_delete into * on GoogleCloudPlatform:master*.

Closes #421.

Batch largely patterend after Transaction: we could maybe even derive Transation from batch.

Note that I dropped the "update auto_id keys" bits on the floor: we can add them if they are important for the usecase.

Coverage remained the same when pulling 65621f3 on tseaver:421-dataset_batch_put_delete into f577b30 on GoogleCloudPlatform:master.

It's pleasantly surprising how simple the tweaks to Connection were!

I have some other ideas floating around that relate to this (including #495). Could we jump on a video chat tomorrow (January 8) AM to discuss?

I was initially thrown off by the Batch concept since I am used to a strict distinction of ndb.put_multi and ndb.delete_multi. However, Mutation is happy to accommodate all.

LGTM save for removing self._id (a remnant of Transaction).

I'll write up a bug outlining a "migration" path based off #495

See: #509 (comment)

I have changes stashed which add the "insert_auto_id*" fixups to Batch. Should I push them, or defer to another PR?

Coverage remained the same when pulling cf6873b on tseaver:421-dataset_batch_put_delete into f577b30 on GoogleCloudPlatform:master.

Let's defer to another PR so we can ask Patrick about it without lots of distracting other code.

Add a 'Batch': collects non-transactional saves / deletes.

…est (#509) * feat: Add support for BatchRecognize Deprecate the `update_config_request` field in the `OperationMetadata` message, which was never used and is output only. PiperOrigin-RevId: 517976288 Source-Link: googleapis/googleapis@7ee7867 Source-Link: googleapis/googleapis-gen@04050e1 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDQwNTBlMTVlN2E0MDlmOWQ0MjFmNjNkYmZkZjM3ZWFjNzJhM2MxNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * docs: fix the resource name format in comment for CreatePhraseSetRequest PiperOrigin-RevId: 518025142 Source-Link: googleapis/googleapis@e354eef Source-Link: googleapis/googleapis-gen@f3e2685 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjNlMjY4NTBlYjU0NWYzN2U0MWEzZGE3MTQyNmQxMzIwMmVhZTAxMyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…509)

* fix!: correct broken ConversationModelEvaluation resource pattern PiperOrigin-RevId: 442646533 Source-Link: googleapis/googleapis@b62c562 Source-Link: googleapis/googleapis-gen@f5c157c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjVjMTU3YzY4MTE1ODQ3ZDc4ZWI4NDEyNzM0Y2I4MmU3ZDU1MTViNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore: Update gapic-generator-python to v1.11.4 PiperOrigin-RevId: 547897126 Source-Link: googleapis/googleapis@c09c75e Source-Link: googleapis/googleapis-gen@45e0ec4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDVlMGVjNDM0MzUxN2NkMGFhNjZiNWNhNjQyMzJhMTgwMmMyZjk0NSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

add code line to set metric label in addition to resource label. make the code sample align with similar samples in other languages.

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@dede53f Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:fac304457974bb530cc5396abd4ab25d26a469cd3bc97cbfb18c8d4324c584eb Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…est (#509) * feat: Add support for BatchRecognize Deprecate the `update_config_request` field in the `OperationMetadata` message, which was never used and is output only. PiperOrigin-RevId: 517976288 Source-Link: googleapis/googleapis@7ee7867 Source-Link: googleapis/googleapis-gen@04050e1 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDQwNTBlMTVlN2E0MDlmOWQ0MjFmNjNkYmZkZjM3ZWFjNzJhM2MxNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * docs: fix the resource name format in comment for CreatePhraseSetRequest PiperOrigin-RevId: 518025142 Source-Link: googleapis/googleapis@e354eef Source-Link: googleapis/googleapis-gen@f3e2685 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjNlMjY4NTBlYjU0NWYzN2U0MWEzZGE3MTQyNmQxMzIwMmVhZTAxMyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 473833416 Source-Link: googleapis/googleapis@565a550 Source-Link: googleapis/googleapis-gen@1ee1a06 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWVlMWEwNmM2ZGUzY2E4Yjg0MzU3MmMxZmRlMDU0OGY4NDIzNjk4OSJ9 feat: add proto annotation for non-ascii field mapping PiperOrigin-RevId: 473815595 Source-Link: googleapis/googleapis@46cfc4c Source-Link: googleapis/googleapis-gen@955ca31 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTU1Y2EzMWQ4MTEwMGQ4MWVkN2UwYWUwNTIyMzU4YWM0NWQ1M2NjOSJ9

) Source-Link: googleapis/synthtool@7804ade Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:eede5672562a32821444a8e803fb984a6f61f2237ea3de229d2de24453f4ae7d

* feat: Add support for autoscaling - Add the parameters min_serve_nodes, max_serve_nodes, and cpu_utilization_percent - Create disable_autoscaling function - Update documentation and tests - Add validation when scaling config was not set correctly.

The old `intersphinx_mapping` format has been removed; it must now map identifiers to (target, inventory) tuples. Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Co-authored-by: Drew Brown <drewbr@google.com>

…#511) Since the result sets for multiqueries have to be merged, if a projection is specified, make sure the projection used for the underlying Datstore queries includes any properties we need for a sorted merge. Fixes #509.

Co-authored-by: Drew Brown <drewbr@google.com>

* updated CHANGELOG.md [ci skip] * updated setup.cfg [ci skip] * updated setup.py [ci skip] Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Closes #500. **PR checklist:** - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-pubsub/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary)

Add a 'Batch': collects non-transactional saves / deletes.

65621f3

Closes #421.

dhermes reviewed Jan 8, 2015
View reviewed changes

Comment thread gcloud/datastore/batch.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes mentioned this pull request Jan 8, 2015

Removing dataset_id from allocate_ids and get_entities #510

Merged

dhermes reviewed Jan 8, 2015
View reviewed changes

Comment thread gcloud/datastore/batch.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Drop fossil.

cf6873b

See: #509 (comment)

dhermes mentioned this pull request Jan 8, 2015

Decouple Transaction from Connection #514

Closed

8 tasks

tseaver added a commit that referenced this pull request Jan 8, 2015

Merge pull request #509 from tseaver/421-dataset_batch_put_delete

3a448f3

Add a 'Batch': collects non-transactional saves / deletes.

tseaver merged commit 3a448f3 into googleapis:master Jan 8, 2015

tseaver deleted the 421-dataset_batch_put_delete branch January 8, 2015 18:17

tseaver mentioned this pull request Jan 8, 2015

Add 'insert_auto_ids' support to 'Batch'. #515

Merged

dhermes mentioned this pull request Jan 10, 2015

Build in regression test case retries #531

Closed

dhermes mentioned this pull request Mar 12, 2015

Looks like we don't expose the Dataset class as datastore.Dataset? #709

Closed

dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015

parthea pushed a commit that referenced this pull request Aug 15, 2023

chore(deps): update dependency google-cloud-dialogflow-cx to v1.20.0 (#…

ee3187e

…509)

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(main): release 5.1.0 (#509 )

b098c28

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

fix: add metric label example to the snippet (#509 )

cd3a4f1

add code line to set metric label in addition to resource label. make the code sample align with similar samples in other languages.

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(main): release 3.2.0 (#509 )

3bf28d8

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025

Tweak ads tests (#509 )

e353e61

parthea added a commit that referenced this pull request Nov 24, 2025

fix: Port to Sphinx 8.0 (#509 )

9f548fb

The old `intersphinx_mapping` format has been removed; it must now map identifiers to (target, inventory) tuples. Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore(deps): update dependency pytest to v7.1.1 (#509 )

d8d8df3

Co-authored-by: Drew Brown <drewbr@google.com>

parthea pushed a commit that referenced this pull request Nov 25, 2025

chore(deps): update dependency pytest to v7.1.1 (#509 )

20ce90e

Co-authored-by: Drew Brown <drewbr@google.com>

parthea pushed a commit that referenced this pull request Nov 26, 2025

chore: release 1.14.3 (#509 )

487c7b4

* updated CHANGELOG.md [ci skip] * updated setup.cfg [ci skip] * updated setup.py [ci skip] Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Mar 6, 2026

fix: s/installation/installation/ (#509 )

a8d75ff

parthea pushed a commit that referenced this pull request Mar 9, 2026

chore(deps): update dependency google-api-core to v2.23.0 (#509 )

2b7f6e2

parthea pushed a commit that referenced this pull request Mar 9, 2026

chore: release 1.41.1 (#509 )

b1f99e2

Add a 'Batch': collects non-transactional saves / deletes. by tseaver · Pull Request #509 · googleapis/google-cloud-python · GitHub

Uh oh!

Add a 'Batch': collects non-transactional saves / deletes. - #509

Add a 'Batch': collects non-transactional saves / deletes.#509
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:421-dataset_batch_put_delete

tseaver commented Jan 8, 2015

Uh oh!

coveralls commented Jan 8, 2015

Uh oh!

tseaver commented Jan 8, 2015

Uh oh!

coveralls commented Jan 8, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Jan 8, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Jan 8, 2015

Uh oh!

tseaver commented Jan 8, 2015

Uh oh!

coveralls commented Jan 8, 2015

Uh oh!

dhermes commented Jan 8, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add a 'Batch': collects non-transactional saves / deletes. by tseaver · Pull Request #509 · googleapis/google-cloud-python · GitHub

Uh oh!

Add a 'Batch': collects non-transactional saves / deletes. - #509

Add a 'Batch': collects non-transactional saves / deletes.#509tseaver merged 2 commits intogoogleapis:mastergoogleapis/google-cloud-python:masterfrom tseaver:421-dataset_batch_put_deleteCopy head branch name to clipboard

Conversation

tseaver commented Jan 8, 2015

Uh oh!

coveralls commented Jan 8, 2015

Uh oh!

tseaver commented Jan 8, 2015

Uh oh!

coveralls commented Jan 8, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Jan 8, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Jan 8, 2015

Uh oh!

tseaver commented Jan 8, 2015

Uh oh!

coveralls commented Jan 8, 2015

Uh oh!

dhermes commented Jan 8, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add a 'Batch': collects non-transactional saves / deletes.#509
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:421-dataset_batch_put_delete