Connection management support (with optional grpc_gcp dependency) - #5553
Merged
theacodes merged 8 commits intoJul 27, 2018
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
theacodes
suggested changes
Jun 29, 2018
Comment thread
api_core/google/api_core/grpc_helpers.py
Outdated
| are passed to :func:`google.auth.default`. | ||
| kwargs: Additional key-word args passed to | ||
| :func:`google.auth.transport.grpc.secure_authorized_channel`. | ||
| :func:`_create_secure_channel`. |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
api_core/google/api_core/grpc_helpers.py
Outdated
| return _wrap_unary_errors(callable_) | ||
|
|
||
|
|
||
| def _create_secure_channel( |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
spanner/google/cloud/spanner_v1/gapic/spanner_client.py
| options = None | ||
|
|
||
| if HAS_GRPC_GCP: | ||
| # Initialize grpc gcp config for spanner api. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
… channel config, add system tests with grpc_gcp
Copy link
Copy Markdown
Contributor
Author
|
Hi @theacodes , I have made some changes as requested. Please take a look, thanks! |
Sorry, something went wrong.
theacodes
suggested changes
Jul 12, 2018
theacodes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looking almost ready. Sorry for the delay on reviewing.
Sorry, something went wrong.
Comment thread
api_core/google/api_core/grpc_helpers.py
| def create_channel(target, | ||
| credentials=None, | ||
| scopes=None, | ||
| ssl_credentials=None, |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
spanner/google/cloud/spanner_v1/gapic/spanner_client.py
| options = None | ||
|
|
||
| if HAS_GRPC_GCP: | ||
| # Initialize grpc gcp config for spanner api. |
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
Author
|
Hi @theacodes , can you take a look at the new changes? |
Sorry, something went wrong.
theacodes
suggested changes
Jul 24, 2018
theacodes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks almost good.
Sorry, something went wrong.
Comment thread
api_core/tests/unit/test_grpc_helpers.py
Outdated
| return_value=(mock.sentinel.credentials, mock.sentinel.projet)) | ||
| @mock.patch('google.auth.transport.grpc.secure_authorized_channel') | ||
| def test_create_channel_implicit(secure_authorized_channel, default): | ||
| @mock.patch('grpc._channel.Channel') |
This comment was marked as spam.
This comment was marked as spam.
theacodes
approved these changes
Jul 27, 2018
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
…onal grpc_gcp dependency) (#5553)
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
…onal grpc_gcp dependency) (#5553)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional grpc_gcp dependency for api_core and spanner_v1. If user has installed grpcio-gcp, then the connection management feature will be enabled, and with the configuration specified in spanner.grpc.config . Otherwise, grpc_gcp won't be imported and everything works as usual.