Requiring Connection.lookup to take a list in datastore. - #582
Conversation
Sorry, something went wrong.
This is in line with our decision in api.get / api.put / api.delete to only take a list and not over-use isinstance().
|
@tseaver I came across this while checking out our two Connection classes while trying to smooth off the surface for storage. ISTM that methods in a Connection should have no side effects and that extra work under the covers should happen elsewhere (e.g. in the Bucket instance methods or in free functions like we define in datastore.api.) I propose that each public method in a Connection should do something concrete (e.g. build a URL) or make a single HTTP API request with no side effects. Currently Connection.lookup (in datastore) breaks this behavior. How do you feel about moving the "do a lookup until all deferred are returned" behavior into api.get (or a helper in the api module). |
Sorry, something went wrong.
|
This PR LGTM. I'm fine with moving the DWIM bits out of Connection, too. |
Sorry, something went wrong.
Requiring Connection.lookup to take a list in datastore.
|
Great. DWIM implemented in #583 |
Sorry, something went wrong.
…eation metadata (#582) - [ ] Regenerate this pull request now. docs: clarify SuggestionFeature enums which are specific to chat agents PiperOrigin-RevId: 478522249 Source-Link: https://togithub.com/googleapis/googleapis/commit/8bd89cd4fc964360198362ef49c72ef90543bf45 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/ddf381e8fcebbdde902df0419b30908d01c63e0e Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGRmMzgxZThmY2ViYmRkZTkwMmRmMDQxOWIzMDkwOGQwMWM2M2UwZSJ9
Source-Link: https://togithub.com/googleapis/synthtool/commit/0ddbff8012e47cde4462fe3f9feab01fbc4cdfd6 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bced5ca77c4dda0fd2f5d845d4035fc3c5d3d6b81f245246a36aee114970082b
* fix: return a tuple when empty result returned on query * test: [] to ()
* chore: updated CHANGELOG.md [ci skip] * chore: updated setup.cfg [ci skip] * chore: updated setup.py Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This is in line with our decision in api.get / api.put / api.delete to only take a list and not over-use isinstance().