FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Making json.loads() optional in gcloud.exceptions.make_exception. by dhermes · Pull Request #628 · googleapis/google-cloud-python · GitHub

Making json.loads() optional in gcloud.exceptions.make_exception. - #628

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:fix-626
Feb 13, 2015
Merged

Making json.loads() optional in gcloud.exceptions.make_exception.#628
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:fix-626

Conversation

dhermes commented Feb 13, 2015

Copy link
Copy Markdown
Contributor

Fixes #626.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 13, 2015

Copy link
Copy Markdown

Coverage remained the same at 100.0% when pulling c3e1351 on dhermes:fix-626 into f73ad7e on GoogleCloudPlatform:master.

tseaver commented Feb 13, 2015

Copy link
Copy Markdown
Contributor

LGTM

dhermes added a commit that referenced this pull request Feb 13, 2015
Making json.loads() optional in gcloud.exceptions.make_exception.
dhermes merged commit bdc591e into googleapis:master Feb 13, 2015
dhermes deleted the fix-626 branch February 13, 2015 18:37
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Aug 21, 2025
Source-Link: googleapis/synthtool@0ddbff8
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bced5ca77c4dda0fd2f5d845d4035fc3c5d3d6b81f245246a36aee114970082b

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 16, 2025
Source-Link: googleapis/synthtool@0ddbff8
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bced5ca77c4dda0fd2f5d845d4035fc3c5d3d6b81f245246a36aee114970082b

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 22, 2025
This PR rewrites the row merging logic to be more correct and improve performance:
- extract row merging logic into its own class to simplify complexity of ReadRows handling
- Use OrderedDict instead of dict() for `{family: { qualifier: [] }}` data, this should maintain serverside ordering (family in creation order and qualifier in lexiographical). 
- define an explicit state machine with states implemented as methods
- add various optimizations like:
  - __slots__ on hot objects to avoid dict lookups
  - avoiding dict lookups for contiguous family and qualifier keys
 
Overall this improves performance by 20% and in my opinion is a lot more readable
parthea pushed a commit that referenced this pull request Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
* chore: update count up_to field type in aggregation queries

PiperOrigin-RevId: 469554568

Source-Link: googleapis/googleapis@c17c5a6

Source-Link: googleapis/googleapis-gen@0b6d950
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGI2ZDk1MDA0MGRhYzdiZDQzMTk0MWJlYTYwZGQ5Njk3NzAwMTFiYyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Source-Link: googleapis/synthtool@50db768
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978
parthea pushed a commit that referenced this pull request Nov 25, 2025
Source-Link: googleapis/synthtool@50db768
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978
parthea pushed a commit that referenced this pull request Mar 2, 2026
parthea pushed a commit that referenced this pull request Mar 6, 2026
…direct value and a transform function is involved (#628)

* fix: lint_setup_py was failing in Kokoro is not fixed

* fix: iexact lookup with Transform expression chash issue #612
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make_exception fails when json.loads fails

4 participants


Back | FazBrowse Home | New Git URL