| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
@foozlevazquez How did you test that the failures in #653 are passing? Can you add unit tests? Also, can you git merge --squash into a single commit? For a 4-line change, 5 commits is too noisy. PS I see you've signed the CLA, @googlebot is useful sometimes! |
Sorry, something went wrong.
|
@foozlevazquez Is this the httplib2 reference you are making:
|
Sorry, something went wrong.
|
Great! Let me know if you need some help and I can make some suggestions / lend a hand. |
Sorry, something went wrong.
|
@dhermes Also, I realized that #653 has a root cause of some python2-3 string crap that is taking place in oauth2client here - So I'm working on a pull-request for that as well. Essentially I'm having to untangle a set of fixes I made in a hacking frenzy... :) Thanks for checking. |
Sorry, something went wrong.
|
That's great! I can help on the oauth2client side as well, or we can loop in @craigcitro The people who added Python 3 support there weren't actually running unit tests (eek!) and I tried to fix most of it in: |
Sorry, something went wrong.
|
+1 to fixing any/all issues in oauth2client. @nathanielmanistaatgoogle or @soltanmm is likely to be quicker than me with the code reviews. |
Sorry, something went wrong.
|
The origin of this all is some code that simply does the following: from gcloud import storage
conn = storage.get_connection('myproj')
[x for x in conn.get_all_buckets()]
The example above dies with the infamous oauth2client.client.AccessTokenRefreshError: invalid_grant exception. i.e. #653 I've initiated googleapis/oauth2client#136 to fix and test the above. To fix problems with make_exception and api_request, I've submitted #675. |
Sorry, something went wrong.
* docs: Minor formatting chore: Update gapic-generator-python to v1.11.5 build: Update rules_python to 0.24.0 PiperOrigin-RevId: 563436317 Source-Link: googleapis/googleapis@42fd37b Source-Link: googleapis/googleapis-gen@280264c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjgwMjY0Y2EwMmZiOTMxNmI0MjM3YTk2ZDBhZjFhMjM0M2E4MWE1NiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Source-Link: googleapis/synthtool@50db768 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978
#671) * fix: updated assets to have text backgroud so it works with dark mode * fix: updated assets to have text backgroud so it works with dark mode
Support multi-row inserts like
```sql
INSERT INTO tbl
VALUES ('a'), ('b')
```
fixes: #670
* samples: delete unspecified sample * fixed lint issue * updated readme
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 423930262 Source-Link: googleapis/googleapis@b0c104f Source-Link: googleapis/googleapis-gen@4289d82 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDI4OWQ4MjAwMGQ1NTQ1NjM1N2YwNWJlMDFiNzc2MzA4MmJiNzdiNiJ9 feat: add api key support
| Back | FazBrowse Home | New Git URL |
fixes: Attribute error thrown in gcloud/exceptions.py #653