FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixed some python2->3 string issues by foozlevazquez · Pull Request #671 · googleapis/google-cloud-python · GitHub

Fixed some python2->3 string issues - #671

Closed
foozlevazquez wants to merge 5 commits into
googleapis:masterfrom
foozlevazquez:master
Closed

foozlevazquez wants to merge 5 commits into
googleapis:masterfrom
foozlevazquez:master

Conversation

Copy link
Copy Markdown

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2015

Copy link
Copy Markdown

Coverage remained the same at 100.0% when pulling 59fff73 on foozlevazquez:master into 56f60bb on GoogleCloudPlatform:master.

Comment thread gcloud/exceptions.py

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dhermes commented Feb 20, 2015

Copy link
Copy Markdown
Contributor

@foozlevazquez How did you test that the failures in #653 are passing? Can you add unit tests?

Also, can you git merge --squash into a single commit? For a 4-line change, 5 commits is too noisy.

PS I see you've signed the CLA, @googlebot is useful sometimes!

dhermes commented Feb 20, 2015

Copy link
Copy Markdown
Contributor

@foozlevazquez Is this the httplib2 reference you are making:

To successfully use http2lib for Python 3, you absolutely must
understand the following sentence:

** THE RESPONSE HEADERS ARE STRINGS, BUT THE CONTENT BODY IS BYTES **

Copy link
Copy Markdown
Author

@dhermes Regarding #653, I tested it by hand on the test case that I had when I ran into these bugs in the first place. I'll look into writing some tests and squashing the commits as well.

Regarding httplib2, yes.

dhermes commented Feb 20, 2015

Copy link
Copy Markdown
Contributor

Great! Let me know if you need some help and I can make some suggestions / lend a hand.

dhermes commented Feb 20, 2015

Copy link
Copy Markdown
Contributor

@foozlevazquez What's up?

Copy link
Copy Markdown
Author

@dhermes
I'm working on a cleaned resubmittal.

Also, I realized that #653 has a root cause of some python2-3 string crap that is taking place in oauth2client here - So I'm working on a pull-request for that as well.

Essentially I'm having to untangle a set of fixes I made in a hacking frenzy... :)

Thanks for checking.

dhermes commented Feb 21, 2015

Copy link
Copy Markdown
Contributor

That's great! I can help on the oauth2client side as well, or we can loop in @craigcitro

The people who added Python 3 support there weren't actually running unit tests (eek!) and I tried to fix most of it in:
googleapis/oauth2client#87

Copy link
Copy Markdown
Contributor

+1 to fixing any/all issues in oauth2client. @nathanielmanistaatgoogle or @soltanmm is likely to be quicker than me with the code reviews.

Copy link
Copy Markdown
Author

The origin of this all is some code that simply does the following:

from gcloud import storage

conn = storage.get_connection('myproj')
[x for x in conn.get_all_buckets()]

The example above dies with the infamous oauth2client.client.AccessTokenRefreshError: invalid_grant exception. i.e. #653
But, this code works under Python2.7, which lead me to find that the headers were being composed incorrectly in oauth2client, specifically here.

I've initiated googleapis/oauth2client#136 to fix and test the above.

To fix problems with make_exception and api_request, I've submitted #675.

vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
* docs: Minor formatting
chore: Update gapic-generator-python to v1.11.5
build: Update rules_python to 0.24.0

PiperOrigin-RevId: 563436317

Source-Link: googleapis/googleapis@42fd37b

Source-Link: googleapis/googleapis-gen@280264c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjgwMjY0Y2EwMmZiOTMxNmI0MjM3YTk2ZDBhZjFhMjM0M2E4MWE1NiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 22, 2025
Source-Link: googleapis/synthtool@50db768
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978
parthea pushed a commit that referenced this pull request Nov 24, 2025
…671)

In the legacy data format, the dotted properties stored in Datastore
were not properly padded for missing values.

Fixes #669
parthea pushed a commit that referenced this pull request Mar 6, 2026
#671)

* fix: updated assets to have text backgroud so it works with dark mode

* fix: updated assets to have text backgroud so it works with dark mode
parthea pushed a commit that referenced this pull request Mar 9, 2026
Support multi-row inserts like
```sql
INSERT INTO tbl
VALUES ('a'), ('b')
```

fixes: #670
parthea pushed a commit that referenced this pull request Mar 9, 2026
* samples: delete unspecified sample

* fixed lint issue

* updated readme
parthea pushed a commit that referenced this pull request Mar 9, 2026
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 423930262

Source-Link: googleapis/googleapis@b0c104f

Source-Link: googleapis/googleapis-gen@4289d82
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDI4OWQ4MjAwMGQ1NTQ1NjM1N2YwNWJlMDFiNzc2MzA4MmJiNzdiNiJ9

feat: add api key support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attribute error thrown in gcloud/exceptions.py

5 participants


Back | FazBrowse Home | New Git URL