FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Begin pubsub regression suite by tseaver · Pull Request #765 · googleapis/google-cloud-python · GitHub

Begin pubsub regression suite - #765

Merged
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:pubsub-begin_regression_suite
Mar 27, 2015
Merged

Begin pubsub regression suite#765
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:pubsub-begin_regression_suite

Conversation

tseaver commented Mar 27, 2015

Copy link
Copy Markdown
Contributor

Uses #764 as a base.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 27, 2015
tseaver mentioned this pull request Mar 27, 2015
9 tasks
tseaver added the api: pubsub Issues related to the Pub/Sub API. label Mar 27, 2015

dhermes commented Mar 27, 2015

Copy link
Copy Markdown
Contributor

Got a lot of unused variables (I assume build failed). Also the do nothing setup and teardownModule aren't needed.

Other questions

  • Why the URI changes?
  • Do you plan on implementing more in this PR?

(Sorry for hacky review. On phone.)

Copy link
Copy Markdown

Coverage remained the same at 100.0% when pulling b906f33 on tseaver:pubsub-begin_regression_suite into b45a909 on GoogleCloudPlatform:master.

tseaver commented Mar 27, 2015

Copy link
Copy Markdown
Contributor Author

I rebased to remove #764 and adjust the tests to accommodate the changed URIs.

Per the API docs, the URIs are all based at https://pubsub.googleapis.com/v1beta2, rather than https://www.googleapis.com/pubsub/v1beta1. I know they are right because the regression tests were all 404ing with non-JSON errors before. :)

tseaver commented Mar 27, 2015

Copy link
Copy Markdown
Contributor Author

I plan to add more tests in later PRs (e.g., once we decide about returning Topic instances from pubsub.api.list_topics()).

Copy link
Copy Markdown

Coverage remained the same at 100.0% when pulling c1ebe23 on tseaver:pubsub-begin_regression_suite into b45a909 on GoogleCloudPlatform:master.

dhermes commented Mar 27, 2015

Copy link
Copy Markdown
Contributor

Still have unused vars HTTP and SHARED_BUCKETS and an unused import httplib2.

Just call me the human linter :)

Other than LGTM (if you don't don't can you squash these fixed into the original commit, 4 commits for tint change is sadness)

Copy link
Copy Markdown

Coverage remained the same at 100.0% when pulling 5981067 on tseaver:pubsub-begin_regression_suite into b45a909 on GoogleCloudPlatform:master.

tseaver commented Mar 27, 2015

Copy link
Copy Markdown
Contributor Author

@dhermes I removed those variables and the import, and squashed it down to two commits.

tseaver added a commit that referenced this pull request Mar 27, 2015
tseaver merged commit 6d08741 into googleapis:master Mar 27, 2015

dhermes commented Mar 27, 2015

Copy link
Copy Markdown
Contributor

Looks great thanks

tseaver deleted the pubsub-begin_regression_suite branch March 27, 2015 17:33
parthea pushed a commit that referenced this pull request Aug 21, 2025
Co-authored-by: Chalmer Lowe <chalmer.lowe@gmail.com>
parthea pushed a commit that referenced this pull request Sep 16, 2025
Co-authored-by: Chalmer Lowe <chalmer.lowe@gmail.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
)

Source-Link: googleapis/synthtool@d6103f4
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:39f0f3f2be02ef036e297e376fe3b6256775576da8a6ccb1d5eeb80f4c8bf8fb

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 25, 2025
)

Source-Link: googleapis/synthtool@d6103f4
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:39f0f3f2be02ef036e297e376fe3b6256775576da8a6ccb1d5eeb80f4c8bf8fb

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 6, 2026
Source-Link: googleapis/synthtool@f15cc72
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bc5eed3804aec2f05fad42aacf973821d9500c174015341f721a984a0825b6fd
parthea pushed a commit that referenced this pull request Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL