FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Removing Bucket.get_default_object_acl. by dhermes · Pull Request #772 · googleapis/google-cloud-python · GitHub

Removing Bucket.get_default_object_acl. - #772

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:remove-get_default_object_acl
Mar 30, 2015
Merged

Removing Bucket.get_default_object_acl.#772
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:remove-get_default_object_acl

Conversation

dhermes commented Mar 28, 2015

Copy link
Copy Markdown
Contributor

No description provided.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2015

Copy link
Copy Markdown

Coverage remained the same at 100.0% when pulling 0c63f07 on dhermes:remove-get_default_object_acl into 4d69bb3 on GoogleCloudPlatform:master.

dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 29, 2015

tseaver commented Mar 30, 2015

Copy link
Copy Markdown
Contributor

LGTM

Comment thread gcloud/storage/bucket.py

This comment was marked as spam.

This comment was marked as spam.

dhermes force-pushed the remove-get_default_object_acl branch from 0c63f07 to f9f5d6f Compare March 30, 2015 19:36

dhermes commented Mar 30, 2015

Copy link
Copy Markdown
Contributor Author

@tseaver Just rebased. Shall we take up the make_public issue elsewhere? It's the last remaining method in #728 without an attached PR.

Copy link
Copy Markdown

Coverage remained the same at 100.0% when pulling f9f5d6f on dhermes:remove-get_default_object_acl into adc0029 on GoogleCloudPlatform:master.

dhermes added a commit that referenced this pull request Mar 30, 2015
dhermes merged commit 522987a into googleapis:master Mar 30, 2015

dhermes commented Mar 30, 2015

Copy link
Copy Markdown
Contributor Author

@tseaver I went ahead and merged. Let me know if you want me to revert based on potential issues with make_public. Otherwise we can discuss in #728

dhermes deleted the remove-get_default_object_acl branch March 30, 2015 20:02
parthea pushed a commit that referenced this pull request Nov 24, 2025
This includes fix fo `data` vs `json` parameter issue and the enum serialization (string instead of number) issue.
parthea pushed a commit that referenced this pull request Nov 26, 2025
Updates `google.auth.external_account.Credentials#info` to not delete items in the dictionary while iterating.
parthea pushed a commit that referenced this pull request Mar 2, 2026
Source-Link: googleapis/synthtool@fdba3ed
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 9, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL