FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add samples for data catalog `lookup_entry`. by tswast · Pull Request #7832 · googleapis/google-cloud-python · GitHub

Add samples for data catalog lookup_entry. - #7832

Closed
tswast wants to merge 4 commits into
googleapis:masterfrom
tswast:datacatalog-samples
Closed

Add samples for data catalog lookup_entry.#7832
tswast wants to merge 4 commits into
googleapis:masterfrom
tswast:datacatalog-samples

Conversation

tswast commented May 1, 2019

Copy link
Copy Markdown
Contributor

These samples use the sample generator to call LookupEntry linked to a BigQuery resource.

Depends on internal CL 246050183 to add the GAPIC config for these samples.

These samples use the sample generator to call LookupEntry linked to a BigQuery resource.

Depends on internal CL 246050183 to add the GAPIC config for these samples.
tswast added type: docs Improvement to the documentation for an API. api: datacatalog Issues related to the Data Catalog API. labels May 1, 2019
tswast requested a review from crwilcox as a code owner May 1, 2019 00:00
googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 1, 2019

tseaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

ISTM that sample code should not be in the main source tree: our normal convention is to place them in datacatalog/docs/samples.py (or perhaps multiple files there).

tswast commented May 1, 2019

Copy link
Copy Markdown
Contributor Author

GitHub doesn't make it easy to see, but the path is samples/google/cloud/datacatalog_v1beta1/gapic/lookup_entry/datacatalog_lookup_entry_by_sql.py. I've complained about the ridiculously long path names to the generator team, though I haven't filed a bug on it yet.

tseaver commented May 1, 2019

Copy link
Copy Markdown
Contributor

@tswast I'm not talking about the source from which the sample is generated, but where we put it in this repo: samples for docs should be in the datacatalog/docs subdirectory, not in google/cloud/datacatalog_v1beta1/gapic/: they aren't part of the library, but rather its docs.

tswast commented May 1, 2019

Copy link
Copy Markdown
Contributor Author

Right, I'm saying it's not in google/, it's in samples/. That's just where the generator sticks it. I could work around that by adding move rules to synth.py, but if we do that, we should notify the generator team about why samples/ doesn't work for us. (IMO, samples/ seems appropriate)

CC @beccasaurus

tseaver commented May 2, 2019

Copy link
Copy Markdown
Contributor

@tswast I noticed just now that BigQuery has a samples subdirectory containing similarly-generated (I think?) samples / snippets. Could we do that for datacatalog, rather than leaving them inside google/cloud?

tswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 2, 2019
yoshi-automation added the 🚨 This issue needs some love. label May 8, 2019

tswast commented Jul 1, 2019

Copy link
Copy Markdown
Contributor Author

tswast closed this Jul 1, 2019
tswast deleted the datacatalog-samples branch July 1, 2019 17:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datacatalog Issues related to the Data Catalog API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing. 🚨 This issue needs some love. type: docs Improvement to the documentation for an API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL