docs(firestore): add documentation for Document,Collection .on_snapshot - #9275
Merged
crwilcox merged 2 commits intoNov 7, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
HemangChothani
requested review from
crwilcox,
frankyn and
tseaver
as code owners
September 24, 2019 05:19
MaxxleLLC
force-pushed
the
Firestore_change_documentation_on_snapshot
branch
from
1047ccd to
b58daea
Compare
September 24, 2019 05:26
MaxxleLLC
force-pushed
the
Firestore_change_documentation_on_snapshot
branch
from
b58daea to
7aff2ba
Compare
September 24, 2019 05:47
Copy link
Copy Markdown
Contributor
|
Looking more closely, the Query.on_snapshot example is also incorrect: the first argument to the callback is a sorted list of keys / document paths in the updated tree. The example should illustrate how a real callback would handle all three arguments. @crwilcox Please clarify / correct my understanding here, and suggest what a good callback example would look like. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@tseaver conventionalcommits.org check throws linting errors for title and give suggestion to edit your pull request title to match Conventional Commit guidelines, due to that i have changed the title. |
Sorry, something went wrong.
crwilcox
approved these changes
Nov 7, 2019
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
…ot (#9275) * add parameters in method on_snapshot of DocumentReference class * docs: add parameters in method on-snapshot of Collection class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #9250