Adding namespace to dataset class. - #934
Merged
dhermes merged 1 commit intoJun 23, 2015
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This does not add support for namespace in `_implicit_environ`. Related to googleapis#902.
Copy link
Copy Markdown
Contributor
Author
|
FWIW I checked where namespace is used in the .proto API. It is only used in PartitionId (along with dataset_id) and the PartitionId message type is only used in Key and RunQueryRequest. Accordingly, the only places we support namespace is:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Cool, as long as it's an option on the client class when that happens I'm satisfied. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM. I plan to rename datastore.dataset.Dataset -> datastore.client.Client after this merges. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
OK SGTM |
Sorry, something went wrong.
dhermes
added a commit
that referenced
this pull request
Jun 23, 2015
Adding namespace to dataset class.
parthea
pushed a commit
that referenced
this pull request
Nov 22, 2025
* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Mar 2, 2026
* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Mar 6, 2026
* fix: guard imports against unsupported pyarrow versions * add unit tests * fix pytype * second try at fixing pytype
parthea
pushed a commit
that referenced
this pull request
Mar 6, 2026
🤖 I have created a release \*beep\* \*boop\* --- ## [2.26.0](https://www.github.com/googleapis/python-bigquery/compare/v2.25.2...v2.26.0) (2021-09-01) ### Features * set the X-Server-Timeout header when timeout is set ([#927](https://www.github.com/googleapis/python-bigquery/issues/927)) ([ba02f24](https://www.github.com/googleapis/python-bigquery/commit/ba02f248ba9c449c34859579a4011f4bfd2f4a93)) ### Bug Fixes * guard imports against unsupported pyarrow versions ([#934](https://www.github.com/googleapis/python-bigquery/issues/934)) ([b289076](https://www.github.com/googleapis/python-bigquery/commit/b28907693bbe889becc1b9c8963f0a7e1ee6c35a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
* fix: rst retry for txn * rst changes and tests * fix * rst stream comment changes * lint * lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not add support for namespace in _implicit_environ.
Related to #902.
As a result of #861 we will likely be removing _implicit_environ which makes this the actual resolution of #902.
/cc @jonparrott