docs(spanner): update description of the timeout_secs parameter - #9381
Merged
tseaver merged 3 commits intoOct 29, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
emar-kar
marked this pull request as ready for review
October 1, 2019 16:24
larkee
reviewed
Oct 22, 2019
Comment thread
spanner/google/cloud/spanner_v1/database.py
Outdated
| :param kw: (Optional) keyword arguments to be passed to ``func``. | ||
| If passed, "timeout_secs" will be removed and used to | ||
| override the default timeout. | ||
| override the default timeout which defines maximum timestamp |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Perhaps reword it to override the retry timeout as default timeout is still vague even with the explanation.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
I got your point and I think it better be called the default retry timeout.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
SGTM
Sorry, something went wrong.
Comment thread
spanner/google/cloud/spanner_v1/session.py
Outdated
| :param kw: (Optional) keyword arguments to be passed to ``func``. | ||
| If passed, "timeout_secs" will be removed and used to | ||
| override the default timeout. | ||
| override the default timeout which defines maximum timestamp |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
See above.
Sorry, something went wrong.
larkee
approved these changes
Oct 23, 2019
larkee
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #9364