feat(cloudbuild): generate v1 - #9510
Conversation
Sorry, something went wrong.
tseaver
left a comment
There was a problem hiding this comment.
The only other library (containeranalysis) which uses google/cloud/devtools doesn't declare it as a namespace package, which means that installing it won't be compatible with this one if we continue to ship the library this PR generates.
Sorry, something went wrong.
busunkim96
left a comment
There was a problem hiding this comment.
I think google/cloud/ is the only namespace package for both?
google/cloud/__init__.py (namespace package):
google/cloud/devtools/__init__.py (regular package):
Sorry, something went wrong.
|
@busunkim96 Try installing google-cloud-containeranalysis and the new google-cloud-build library in the same virtualenv: the fact that google.cloud.devtools is not declared by both as a namespace package means that one of the two won't be importable (or maybe the second install will fail, depending on pip's behavior). |
Sorry, something went wrong.
|
@tseaver Ah I see. So my options are:
I'll probably do 1, and note in the README that you need google-cloud-containeranalysis>=x.x.x to be able to install side by side with google-cloud-build. |
Sorry, something went wrong.
I named the directory cloudbuild rather than build.
The generator names the package google-cloud-cloudbuild, but I'd be open to naming it google-cloud-build. Thoughts?
Product team said they preferred google-cloud-build, so I've added a synth replace.
TODO: