FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Making datastore client inherit from base client by dhermes · Pull Request #955 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Making datastore client inherit from base client - #955

Closed
dhermes wants to merge 1 commit into
googleapis:masterfrom
dhermes:client-parent-in-datastore
ConversationCommits (1)ChecksFiles changed
Closed

Making datastore client inherit from base client#955
dhermes wants to merge 1 commit into
googleapis:masterfrom
dhermes:client-parent-in-datastore

Conversation

dhermes commented Jun 26, 2015

Copy link
Copy Markdown
Contributor

NOTE: This has #953 as a diffbase.

@tseaver This will likely conflict with #944, it's really more of an "ideas" PR.

dhermes added api: datastore Issues related to the Datastore API. api: core labels Jun 26, 2015
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2015
This was referenced Jul 1, 2015
Merged
Closed
Making datastore client inherit from base class.
dd93c80 
This required lots of changes since the tests assume
a client only optionally has a connection attached.
dhermes force-pushed the client-parent-in-datastore branch from 793d7a8 to dd93c80 Compare July 21, 2015 16:33

dhermes commented Jul 21, 2015

Copy link
Copy Markdown
Contributor Author

@tseaver PTAL. I re-created this PR after you finished migrating datastore to the client pattern.

tseaver commented Jul 21, 2015

Copy link
Copy Markdown
Contributor

Crap, I was just working on this one. :(

tseaver mentioned this pull request Jul 21, 2015
Merged

dhermes commented Jul 21, 2015

Copy link
Copy Markdown
Contributor Author

What to do? Did you forget this PR existed?

tseaver commented Jul 21, 2015

Copy link
Copy Markdown
Contributor

I think I prefer #1004: I was able to simplify some of the testing interactions w/ the mocked connection, and reduce coupling between 'test_client' and 'test_connection'.

tseaver commented Jul 21, 2015

Copy link
Copy Markdown
Contributor

I didn't realize you were refreshing it. :(

dhermes commented Jul 21, 2015

Copy link
Copy Markdown
Contributor Author

Closing. Bowing out to #1004

dhermes closed this Jul 21, 2015
dhermes deleted the client-parent-in-datastore branch July 21, 2015 17:43

tseaver commented Jul 21, 2015

Copy link
Copy Markdown
Contributor

Sorry about that. I should've checked with you in Hangouts first.

dhermes commented Jul 21, 2015

Copy link
Copy Markdown
Contributor Author

No worries.

tseaver added a commit that referenced this pull request Jul 21, 2015
Merge pull request #1004 from tseaver/955-rework_datastore_client_usi…
df79324 
…ng_base

Refresh #955:  make datastore.Client derive from base client.
parthea pushed a commit that referenced this pull request Nov 22, 2025
chore: fix prerelease_deps (#955)
ccd8781
parthea pushed a commit that referenced this pull request Nov 24, 2025
chore: allow 'google-api-core' 2.x versions (#956)
ed6e038 
Closes #955.

Co-authored-by: Bu Sun Kim <busunkim@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
chore(main): release 2.18.0 (#955)
f7094fe 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
fix: require proto-plus >= 1.25 for Python 3.13 (#955)
ee741f4 
+
parthea pushed a commit that referenced this pull request Nov 25, 2025
fix: require proto-plus >= 1.25 for Python 3.13 (#955)
13bba01 
+
parthea pushed a commit that referenced this pull request Nov 26, 2025
chore(main): release 2.4.1 (#955)
e51c765 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 2, 2026
chore: fix prerelease_deps (#955)
7da61b3
parthea added a commit that referenced this pull request Mar 2, 2026
build(deps): [autoapprove] bump cryptography from 41.0.0 to 41.0.2 (#955
56a9075 
)

Source-Link: googleapis/synthtool@d6103f4
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:39f0f3f2be02ef036e297e376fe3b6256775576da8a6ccb1d5eeb80f4c8bf8fb

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: core api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL