fix(speech): move 'speaker_tag' field from 'SpeakerDiarizationConfig' to 'WordInfo' (via synth) - #9576
Merged
tseaver merged 1 commit intoOct 31, 2019
Merged
fix(speech): move 'speaker_tag' field from 'SpeakerDiarizationConfig' to 'WordInfo' (via synth)#9576tseaver merged 1 commit into
tseaver merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…nt library generator.
tseaver
approved these changes
Oct 31, 2019
Comment thread
speech/google/cloud/speech_v1/proto/cloud_speech.proto
| // top alternative. | ||
| int32 speaker_tag = 5 | ||
| [(google.api.field_behavior) = OUTPUT_ONLY]; | ||
| } |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This is potentially a breaking change, although it looks obviously correct (the unchanged docstring implies that the speaker_tag should always have been associated with a word).
The field was added to SpeakerDiarizationConfig on 2019-09-24, which is later than any release of google-cloud-speech, so I think we can let it slide.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This may be reverted tomorrow given discussions in the Yoshi chatroom. Will be keeping an eye on it.
Sorry, something went wrong.
atulep
pushed a commit
that referenced
this pull request
Apr 3, 2023
… to 'WordInfo' (via synth) (#9576)
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
… to 'WordInfo' (via synth) (#9576)
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
… to 'WordInfo' (via synth) (#9576)
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
… to 'WordInfo' (via synth) (#9576)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Log from Synthtoolsynthtool > Executing /tmpfs/src/git/autosynth/working_repo/speech/synth.py. synthtool > Ensuring dependencies. synthtool > Pulling artman image. latest: Pulling from googleapis/artman Digest: sha256:75b38a3b073a7b243545f2332463096624c802bb1e56b8cb6f22ba1ecd325fa9 Status: Image is up to date for googleapis/artman:latest synthtool > Cloning googleapis. synthtool > Running generator for google/cloud/speech/artman_speech_v1p1beta1.yaml. synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1. synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1p1beta1/cloud_speech.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/google/cloud/speech_v1p1beta1/proto/cloud_speech.proto synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/google/cloud/speech_v1p1beta1/proto. synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1p1beta1/samples/test/speech_transcribe_auto_punctuation_beta.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/v1p1beta1/test/speech_transcribe_auto_punctuation_beta.test.yaml synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1p1beta1/samples/test/speech_quickstart_beta.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/v1p1beta1/test/speech_quickstart_beta.test.yaml synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1p1beta1/samples/test/speech_transcribe_diarization_beta.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/v1p1beta1/test/speech_transcribe_diarization_beta.test.yaml synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1p1beta1/samples/test/speech_transcribe_multilanguage_beta.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/v1p1beta1/test/speech_transcribe_multilanguage_beta.test.yaml synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1p1beta1/samples/test/speech_transcribe_recognition_metadata_beta.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/v1p1beta1/test/speech_transcribe_recognition_metadata_beta.test.yaml synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1p1beta1/samples/test/speech_transcribe_word_level_confidence_beta.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/v1p1beta1/test/speech_transcribe_word_level_confidence_beta.test.yaml synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1p1beta1/samples/test/speech_contexts_classes_beta.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/v1p1beta1/test/speech_contexts_classes_beta.test.yaml synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1p1beta1/samples/test/speech_adaptation_beta.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/v1p1beta1/test/speech_adaptation_beta.test.yaml synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/brooklyn_bridge.mp3 to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/resources/brooklyn_bridge.mp3 synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/brooklyn_bridge.raw to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/resources/brooklyn_bridge.raw synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/brooklyn_bridge.flac to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/resources/brooklyn_bridge.flac synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/brooklyn_bridge.wav to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/resources/brooklyn_bridge.wav synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/hello.raw to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/resources/hello.raw synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/hello.wav to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/resources/hello.wav synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/multi.flac to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/resources/multi.flac synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/multi.wav to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/resources/multi.wav synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/commercial_mono.wav to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/resources/commercial_mono.wav synthtool > Writing samples manifest ['gen-manifest', '--env=python', '--bin=python3', '--output=v1p1beta1/test/samples.manifest.yaml', '--chdir={@manifest_dir}/../..', 'v1p1beta1/speech_contexts_classes_beta.py', 'v1p1beta1/speech_transcribe_multilanguage_beta.py', 'v1p1beta1/speech_transcribe_auto_punctuation_beta.py', 'v1p1beta1/speech_adaptation_beta.py', 'v1p1beta1/speech_transcribe_diarization_beta.py', 'v1p1beta1/speech_quickstart_beta.py', 'v1p1beta1/speech_transcribe_recognition_metadata_beta.py', 'v1p1beta1/speech_transcribe_word_level_confidence_beta.py'] synthtool > Running generator for google/cloud/speech/artman_speech_v1.yaml. synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1. synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1/cloud_speech.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/google/cloud/speech_v1/proto/cloud_speech.proto synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/google/cloud/speech_v1/proto. synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1/samples/test/speech_transcribe_async_gcs.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/v1/test/speech_transcribe_async_gcs.test.yaml synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1/samples/test/speech_transcribe_async_word_time_offsets_gcs.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/v1/test/speech_transcribe_async_word_time_offsets_gcs.test.yaml synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1/samples/test/speech_transcribe_model_selection.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/v1/test/speech_transcribe_model_selection.test.yaml synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1/samples/test/speech_transcribe_multichannel.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/v1/test/speech_transcribe_multichannel.test.yaml synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1/samples/test/speech_transcribe_model_selection_gcs.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/v1/test/speech_transcribe_model_selection_gcs.test.yaml synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1/samples/test/speech_transcribe_sync_gcs.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/v1/test/speech_transcribe_sync_gcs.test.yaml synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1/samples/test/speech_transcribe_enhanced_model.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/v1/test/speech_transcribe_enhanced_model.test.yaml synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1/samples/test/speech_transcribe_async.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/v1/test/speech_transcribe_async.test.yaml synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1/samples/test/speech_transcribe_multichannel_gcs.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/v1/test/speech_transcribe_multichannel_gcs.test.yaml synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1/samples/test/speech_transcribe_sync.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/v1/test/speech_transcribe_sync.test.yaml synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/brooklyn_bridge.mp3 to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/resources/brooklyn_bridge.mp3 synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/brooklyn_bridge.raw to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/resources/brooklyn_bridge.raw synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/brooklyn_bridge.flac to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/resources/brooklyn_bridge.flac synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/brooklyn_bridge.wav to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/resources/brooklyn_bridge.wav synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/hello.raw to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/resources/hello.raw synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/hello.wav to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/resources/hello.wav synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/multi.flac to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/resources/multi.flac synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/multi.wav to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/resources/multi.wav synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/commercial_mono.wav to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/resources/commercial_mono.wav synthtool > Writing samples manifest ['gen-manifest', '--env=python', '--bin=python3', '--output=v1/test/samples.manifest.yaml', '--chdir={@manifest_dir}/../..', 'v1/speech_transcribe_multichannel.py', 'v1/speech_transcribe_sync_gcs.py', 'v1/speech_transcribe_async_gcs.py', 'v1/speech_transcribe_multichannel_gcs.py', 'v1/speech_transcribe_async.py', 'v1/speech_transcribe_model_selection_gcs.py', 'v1/speech_transcribe_async_word_time_offsets_gcs.py', 'v1/speech_transcribe_enhanced_model.py', 'v1/speech_transcribe_model_selection.py', 'v1/speech_transcribe_sync.py'] synthtool > Replaced 'from google\\.cloud import speech_(.+?)$' in tests/unit/gapic/v1/test_speech_client_v1.py. synthtool > Replaced 'from google\\.cloud import speech_(.+?)$' in tests/unit/gapic/v1p1beta1/test_speech_client_v1p1beta1.py. .coveragerc .flake8 MANIFEST.in noxfile.py.j2 setup.cfg Running session blacken Creating virtual environment (virtualenv) using python3.6 in .nox/blacken pip install black==19.3b0 black docs google tests noxfile.py setup.py samples reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1/gapic/speech_client_config.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1/gapic/enums.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1/gapic/transports/speech_grpc_transport.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1/types.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1/proto/cloud_speech_pb2_grpc.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1p1beta1/gapic/enums.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1/gapic/speech_client.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1p1beta1/gapic/speech_client_config.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1p1beta1/gapic/transports/speech_grpc_transport.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1p1beta1/gapic/speech_client.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1p1beta1/proto/cloud_speech_pb2_grpc.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1p1beta1/types.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1/speech_transcribe_async.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1/speech_transcribe_async_gcs.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1/speech_transcribe_async_word_time_offsets_gcs.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1/speech_transcribe_enhanced_model.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1/speech_transcribe_model_selection.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1/speech_transcribe_model_selection_gcs.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1/speech_transcribe_multichannel.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1/speech_transcribe_multichannel_gcs.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1/speech_transcribe_sync.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1/speech_transcribe_sync_gcs.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1p1beta1/speech_adaptation_beta.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1p1beta1/speech_contexts_classes_beta.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1p1beta1/speech_quickstart_beta.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1p1beta1/speech_transcribe_auto_punctuation_beta.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1p1beta1/speech_transcribe_diarization_beta.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1p1beta1/speech_transcribe_multilanguage_beta.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1p1beta1/speech_transcribe_recognition_metadata_beta.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1p1beta1/speech_transcribe_word_level_confidence_beta.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/tests/unit/gapic/v1/test_speech_client_v1.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/tests/unit/gapic/v1p1beta1/test_speech_client_v1p1beta1.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1/proto/cloud_speech_pb2.py reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1p1beta1/proto/cloud_speech_pb2.py All done! ✨ 🍰 ✨ 35 files reformatted, 17 files left unchanged. Session blacken was successful. synthtool > Cleaned up 2 temporary directories. synthtool > Wrote metadata to synth.metadata.