tests(dlp): normalize VPCSC configuration in systests - #9608
Merged
tseaver merged 5 commits intoNov 11, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
10 tasks
busunkim96
approved these changes
Nov 5, 2019
Comment thread
dlp/tests/system/gapic/v2/test_system_dlp_service_v2_vpcsc.py
Outdated
- Move 'skip_unless_inside_vpcsc' to class scope. - Drop 'skip_unless_outside_project': it is guaranteed to be set when running tests inside VPCSC. - Drop never-reached branch for outside in '_do_test'. - Don't swallow unexpected exceptions inside '_is_rejected.
Copy link
Copy Markdown
Contributor
Author
|
I tagged with "do not merge" because I believe we should refactor all these un-idiomatic tests along the lines of the changes in #9618. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@busunkim96 I removed the "do not merge" label after updating the tests to follow the pattern in #9618. |
Sorry, something went wrong.
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toward #9580